cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(language-service): Turn on strict mode for test project (#32783)

Browse Source 
This is the last part in refactoring of the test project.
This PR turns on strict mode for typechecking and fixed tests that
fail under this mode.

PR Close #32783
This commit is contained in:
Keen Yee Liau
2019-09-19 17:04:02 -07:00
committed by atscott
parent 9e7aa60ae7
commit 28358b6395
8 changed files with 70 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/language-service/test/test_utils.ts
View File

@ -79,6 +79,17 @@ function loadTourOfHeroes(): ReadonlyMap<string, string> {
}
const TOH = loadTourOfHeroes();
const COMPILER_OPTIONS: Readonly<ts.CompilerOptions> = {
target: ts.ScriptTarget.ES5,
module: ts.ModuleKind.CommonJS,
moduleResolution: ts.ModuleResolutionKind.NodeJs,
emitDecoratorMetadata: true,
experimentalDecorators: true,
removeComments: false,
noImplicitAny: false,
lib: ['lib.es2015.d.ts', 'lib.dom.d.ts'],
strict: true,
};
export class MockTypescriptHost implements ts.LanguageServiceHost {
private angularPath?: string;
@ -98,16 +109,7 @@ export class MockTypescriptHost implements ts.LanguageServiceHost {
const support = setup();
this.nodeModulesPath = path.posix.join(support.basePath, 'node_modules');
this.angularPath = path.posix.join(this.nodeModulesPath, '@angular');
this.options = {
target: ts.ScriptTarget.ES5,
module: ts.ModuleKind.CommonJS,
moduleResolution: ts.ModuleResolutionKind.NodeJs,
emitDecoratorMetadata: true,
experimentalDecorators: true,
removeComments: false,
noImplicitAny: false,
lib: ['lib.es2015.d.ts', 'lib.dom.d.ts'],
};
this.options = COMPILER_OPTIONS;
}
override(fileName: string, content: string) {
@ -133,12 +135,12 @@ export class MockTypescriptHost implements ts.LanguageServiceHost {
forgetAngular() { this.angularPath = undefined; }
overrideOptions(cb: (options: ts.CompilerOptions) => ts.CompilerOptions) {
this.options = cb((Object as any).assign({}, this.options));
overrideOptions(options: Partial<ts.CompilerOptions>) {
this.options = {...this.options, ...options};
this.projectVersion++;
}
getCompilationSettings(): ts.CompilerOptions { return this.options; }
getCompilationSettings(): ts.CompilerOptions { return {...this.options}; }
getProjectVersion(): string { return this.projectVersion.toString(); }
@ -199,6 +201,7 @@ export class MockTypescriptHost implements ts.LanguageServiceHost {
reset() {
this.overrides.clear();
this.overrideDirectory.clear();
this.options = COMPILER_OPTIONS;
}
private getRawFileContent(fileName: string): string|undefined {