cargdev/angular
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(upgrade): support $element in upgraded component template/templateUrl functions (#31637)

Browse Source 
PR Close #31637
This commit is contained in:
Ben Black
2019-07-18 16:48:28 -04:00
committed by Miško Hevery
parent 87ce4e997b
commit 29e1c53a31
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/upgrade/static/test/integration/upgrade_component_spec.ts
View File

@ -106,12 +106,12 @@ withEachNg1Version(() => {
});
}));
it('should support not pass any arguments to `template` function', async(() => {
it('should pass $element to `template` function and not $attrs', async(() => {
// Define `ng1Component`
const ng1Component: angular.IComponent = {
template: ($attrs: angular.IAttributes, $element: angular.IAugmentedJQuery) => {
expect($attrs).toBeUndefined();
expect($element).toBeUndefined();
expect($element).toBeDefined();
return 'Hello, Angular!';
}
@ -241,12 +241,12 @@ withEachNg1Version(() => {
});
}));
it('should support not pass any arguments to `templateUrl` function', async(() => {
it('should pass $element to `templateUrl` function and not $attrs', async(() => {
// Define `ng1Component`
const ng1Component: angular.IComponent = {
templateUrl: ($attrs: angular.IAttributes, $element: angular.IAugmentedJQuery) => {
expect($attrs).toBeUndefined();
expect($element).toBeUndefined();
expect($element).toBeDefined();
return 'ng1.component.html';
}