From 29f57e315edf09b8657909ba83293a307d64c2b4 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Tue, 19 Feb 2019 18:52:44 +0100 Subject: [PATCH] build: enable bundle_dts for router package (#28833) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR also changes the name of `EmptyOutletComponent` to `ɵEmptyOutletComponent`. This is because `ngcc` requires the node to retain the original name while dts bundler will rename the node is it's only exported using the aliases. Example typings files: ```ts declare class EmptyOutletComponent { } export {EmptyOutletComponent as ɵEmptyOutletComponent} ``` will be emitted as ```ts export declare class ɵEmptyOutletComponent { } ``` PR Close #28833 --- packages/router/BUILD.bazel | 1 + packages/router/src/components/empty_outlet.ts | 6 ++++-- packages/router/src/private_export.ts | 2 +- packages/router/testing/BUILD.bazel | 1 + packages/router/upgrade/BUILD.bazel | 1 + 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/router/BUILD.bazel b/packages/router/BUILD.bazel index 59ee3d3920..ee69969bbb 100644 --- a/packages/router/BUILD.bazel +++ b/packages/router/BUILD.bazel @@ -10,6 +10,7 @@ ng_module( "src/**/*.ts", ], ), + bundle_dts = True, deps = [ "//packages/common", "//packages/core", diff --git a/packages/router/src/components/empty_outlet.ts b/packages/router/src/components/empty_outlet.ts index d5e99f5e68..fcef102e46 100644 --- a/packages/router/src/components/empty_outlet.ts +++ b/packages/router/src/components/empty_outlet.ts @@ -18,5 +18,7 @@ import {Component} from '@angular/core'; * to this `EmptyOutletComponent`. */ @Component({template: ``}) -export class EmptyOutletComponent { -} \ No newline at end of file +export class ɵEmptyOutletComponent { +} + +export {ɵEmptyOutletComponent as EmptyOutletComponent}; diff --git a/packages/router/src/private_export.ts b/packages/router/src/private_export.ts index aca5be0260..27c8e2686e 100644 --- a/packages/router/src/private_export.ts +++ b/packages/router/src/private_export.ts @@ -7,6 +7,6 @@ */ -export {EmptyOutletComponent as ɵEmptyOutletComponent} from './components/empty_outlet'; +export {ɵEmptyOutletComponent} from './components/empty_outlet'; export {ROUTER_PROVIDERS as ɵROUTER_PROVIDERS} from './router_module'; export {flatten as ɵflatten} from './utils/collection'; diff --git a/packages/router/testing/BUILD.bazel b/packages/router/testing/BUILD.bazel index 9e0b86acda..828c714b10 100644 --- a/packages/router/testing/BUILD.bazel +++ b/packages/router/testing/BUILD.bazel @@ -7,6 +7,7 @@ exports_files(["package.json"]) ng_module( name = "testing", srcs = glob(["**/*.ts"]), + bundle_dts = True, deps = [ "//packages/common", "//packages/common/testing", diff --git a/packages/router/upgrade/BUILD.bazel b/packages/router/upgrade/BUILD.bazel index 9004665b68..a1a2961a20 100644 --- a/packages/router/upgrade/BUILD.bazel +++ b/packages/router/upgrade/BUILD.bazel @@ -12,6 +12,7 @@ ng_module( "src/**/*.ts", ], ), + bundle_dts = True, deps = [ "//packages/common", "//packages/core",