cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): ngtsc should pay attention to declaration order (#25392)

Browse Source 
When generating the 'directives:' property of ngComponentDef, ngtsc
needs to be conscious of declaration order. If a directive being
written into the array is declarated after the component currently
being compiled, then the entire directives array needs to be wrapped
in a closure.

This commit fixes ngtsc to pay attention to such ordering issues
within directives arrays.

PR Close #25392
This commit is contained in:
Alex Rickabaugh
2018-08-06 14:49:35 +02:00
committed by Ben Lesh
parent 6f085f8610
commit 2befc65777
7 changed files with 94 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/compiler-cli/test/compliance/r3_compiler_compliance_spec.ts
View File

@ -1002,7 +1002,7 @@ describe('compiler compliance', () => {
$r3$.ɵEe(1, "div", $e0_attrs$);
}
},
directives:[SomeDirective]
directives: function () { return [SomeDirective]; }
});`;
const result = compile(files, angularFiles);
@ -1582,7 +1582,7 @@ describe('compiler compliance', () => {
}
if (rf & 2) { $r3$.ɵp(1,"forOf",$r3$.ɵb(ctx.items)); }
},
directives: [ForOfDirective]
directives: function() { return [ForOfDirective]; }
});
`;
@ -1660,7 +1660,7 @@ describe('compiler compliance', () => {
$r3$.ɵp(1, "forOf", $r3$.ɵb(ctx.items));
}
},
directives: [ForOfDirective]
directives: function() { return [ForOfDirective]; }
});
`;
@ -1758,7 +1758,7 @@ describe('compiler compliance', () => {
$r3$.ɵp(1, "forOf", $r3$.ɵb(ctx.items));
}
},
directives: [ForOfDirective]
directives: function () { return [ForOfDirective]; }
});`;
const result = compile(files, angularFiles);