build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 (#25920)

PR Close #25920

tools/defaults.bzl

@@ -73,18 +73,19 @@ def ivy_ng_module(name, tsconfig = None, entry_point = None, testonly = False, *
   _internal_global_ng_module(name = name, flat_module_out_file = name, tsconfig = tsconfig, entry_point = entry_point, testonly = testonly, **kwargs)
 
 def ng_package(name, node_modules = DEFAULT_NODE_MODULES, readme_md = None, license_banner = None, **kwargs):
-  if not readme_md:
-    readme_md = "//packages:README.md"
-  if not license_banner:
-    license_banner = "//packages:license-banner.txt"
+    if not readme_md:
+        readme_md = "//packages:README.md"
+    if not license_banner:
+        license_banner = "//packages:license-banner.txt"
 
-  _ng_package(
-      name = name,
-      readme_md = readme_md,
-      license_banner = license_banner,
-      replacements = PKG_GROUP_REPLACEMENTS,
-      node_modules = node_modules,
-      **kwargs)
+    _ng_package(
+        name = name,
+        readme_md = readme_md,
+        license_banner = license_banner,
+        replacements = PKG_GROUP_REPLACEMENTS,
+        node_modules = node_modules,
+        **kwargs
+    )
 
 def npm_package(name, replacements = {}, **kwargs):
   _npm_package(
@@ -100,27 +101,28 @@ def ts_web_test_suite(bootstrap = [], deps = [], **kwargs):
     "//tools/testing:browser",
   ] + deps
 
-  _ts_web_test_suite(
-      bootstrap = bootstrap,
-      deps = local_deps,
-      # Run unit tests on local Chromium by default.
-      # You can exclude tests based on tags, e.g. to skip Firefox testing,
-      #   `bazel test --test_tag_filters=-browser:firefox-local [targets]`
-      browsers = [
-          "@io_bazel_rules_webtesting//browsers:chromium-local",
-          # Don't test on local Firefox by default, for faster builds.
-          # We think that bugs in Angular tend to be caught the same in any
-          # evergreen browser.
-          # "@io_bazel_rules_webtesting//browsers:firefox-local",
-          # TODO(alexeagle): add remote browsers on SauceLabs
-      ],
-      **kwargs)
+    _ts_web_test_suite(
+        bootstrap = bootstrap,
+        deps = local_deps,
+        # Run unit tests on local Chromium by default.
+        # You can exclude tests based on tags, e.g. to skip Firefox testing,
+        #   `bazel test --test_tag_filters=-browser:firefox-local [targets]`
+        browsers = [
+            "@io_bazel_rules_webtesting//browsers:chromium-local",
+            # Don't test on local Firefox by default, for faster builds.
+            # We think that bugs in Angular tend to be caught the same in any
+            # evergreen browser.
+            # "@io_bazel_rules_webtesting//browsers:firefox-local",
+            # TODO(alexeagle): add remote browsers on SauceLabs
+        ],
+        **kwargs
+    )
 
 def nodejs_binary(node_modules = DEFAULT_NODE_MODULES, **kwargs):
-  _nodejs_binary(node_modules = node_modules, **kwargs)
+    _nodejs_binary(node_modules = node_modules, **kwargs)
 
 def jasmine_node_test(node_modules = DEFAULT_NODE_MODULES, **kwargs):
-  _jasmine_node_test(node_modules = node_modules, **kwargs)
+    _jasmine_node_test(node_modules = node_modules, **kwargs)
 
 def ng_rollup_bundle(node_modules = DEFAULT_NODE_MODULES, **kwargs):
-  _ng_rollup_bundle(node_modules = node_modules, **kwargs)
+    _ng_rollup_bundle(node_modules = node_modules, **kwargs)

tools/ng_setup_workspace.bzl

@@ -11,17 +11,17 @@ load("@angular//packages/bazel/src:ng_setup_workspace.bzl", _ng_setup_workspace
 def ng_setup_workspace():
   """This repository rule should be called from your WORKSPACE file.
 
-  It creates some additional Bazel external repositories that are used internally
-  to build angular
-  """
-  yarn_install(
-      name = "angular_deps",
-      package_json = "@angular//:package.json",
-      yarn_lock = "@angular//:yarn.lock",
-      data = ["@angular//:tools/yarn/check-yarn.js", "@angular//:tools/postinstall-patches.js"],
-      manual_build_file_contents = """package(default_visibility = ["//visibility:public"])
+    It creates some additional Bazel external repositories that are used internally
+    to build angular
+    """
+    yarn_install(
+        name = "angular_deps",
+        package_json = "@angular//:package.json",
+        yarn_lock = "@angular//:yarn.lock",
+        data = ["@angular//:tools/yarn/check-yarn.js", "@angular//:tools/postinstall-patches.js"],
+        manual_build_file_contents = """package(default_visibility = ["//visibility:public"])
 filegroup(
-    name = "node_modules",  
+    name = "node_modules",
     srcs = glob(["/".join([
         "node_modules",
         pkg,

tools/symbol-extractor/index.bzl

@@ -6,35 +6,35 @@
 """This test verifies that a set of top level symbols from a javascript file match a gold file.
 """
 
-# This does a deep import under //internal because of not wanting the wrapper macro 
+# This does a deep import under //internal because of not wanting the wrapper macro
 # because it introduces an extra target_bin target.
 load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_test", "nodejs_binary")
 
 DEFAULT_NODE_MODULES = "@angular_deps//:node_modules"
 
 def js_expected_symbol_test(name, src, golden, node_modules = DEFAULT_NODE_MODULES, **kwargs):
-  """This test verifies that a set of top level symbols from a javascript file match a gold file.
-  """
-  all_data = [src, golden]
-  all_data += [Label("//tools/symbol-extractor:lib")]
-  all_data += [Label("@bazel_tools//tools/bash/runfiles")]
-  entry_point = "angular/tools/symbol-extractor/cli.js"
+    """This test verifies that a set of top level symbols from a javascript file match a gold file.
+    """
+    all_data = [src, golden]
+    all_data += [Label("//tools/symbol-extractor:lib")]
+    all_data += [Label("@bazel_tools//tools/bash/runfiles")]
+    entry_point = "angular/tools/symbol-extractor/cli.js"
 
-  nodejs_test(
-      name = name,
-      data = all_data,
-      entry_point = entry_point,
-      templated_args = ["$(location %s)" % src, "$(location %s)" % golden],
-      node_modules = node_modules,
-      **kwargs
-  )
+    nodejs_test(
+        name = name,
+        data = all_data,
+        entry_point = entry_point,
+        templated_args = ["$(location %s)" % src, "$(location %s)" % golden],
+        node_modules = node_modules,
+        **kwargs
+    )
 
-  nodejs_binary(
-      name = name + '.accept',
-      testonly = True,
-      data = all_data,
-      entry_point = entry_point,
-      templated_args = ["$(location %s)" % src, "$(location %s)" % golden, '--accept'],
-      node_modules = node_modules,
-      **kwargs
-  )
+    nodejs_binary(
+        name = name + ".accept",
+        testonly = True,
+        data = all_data,
+        entry_point = entry_point,
+        templated_args = ["$(location %s)" % src, "$(location %s)" % golden, "--accept"],
+        node_modules = node_modules,
+        **kwargs
+    )