Revert "fix(compiler): mark NgModuleFactory construction as not side effectful (#38147)" (#38303)

This reverts commit 7f8c2225f2.

This commit caused test failures internally, which were traced back to the
optimizer removing NgModuleFactory constructor calls when those calls caused
side-effectful registration of NgModules by their ids.

PR Close #38303

packages/core/src/core_render3_private_export.ts

@@ -292,6 +292,5 @@ export {
   ɵɵsanitizeUrl,
   ɵɵsanitizeUrlOrResourceUrl,
 } from './sanitization/sanitization';
-export {noSideEffects as ɵnoSideEffects} from './util/closure';
 
 // clang-format on

packages/core/src/r3_symbols.ts

@@ -28,7 +28,6 @@ export {ɵɵdefineNgModule} from './render3/definition';
 export {ɵɵFactoryDef} from './render3/interfaces/definition';
 export {setClassMetadata} from './render3/metadata';
 export {NgModuleFactory} from './render3/ng_module_ref';
-export {noSideEffects as ɵnoSideEffects} from './util/closure';