From 2cf6b809aef0a482275f7f0965afc94524e6b374 Mon Sep 17 00:00:00 2001 From: Kara Erickson Date: Fri, 15 May 2020 15:00:33 -0700 Subject: [PATCH] build: move CHANGELOG to public-api approval group (#37143) Previously, the CHANGELOG file was caught under the general "*" glob, which meant that it fell under the dev-infra approval group. This does not really make sense since it has more to do with public-facing changes. As such, this commit moves the CHANGELOG file specifically to the public-api approval group. PR Close #37143 --- .pullapprove.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 08f1c7f33c..5256161183 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -947,7 +947,7 @@ groups: conditions: - *can-be-global-approved - > - contains_any_globs(files, [ + contains_any_globs(files.exclude("CHANGELOG.md"), [ '*', '.circleci/**', '.devcontainer/**', @@ -1019,6 +1019,7 @@ groups: - > contains_any_globs(files, [ 'goldens/public-api/**', + 'CHANGELOG.md', 'docs/NAMING.md', 'aio/content/guide/glossary.md', 'aio/content/guide/styleguide.md',