feat(ivy): exclude declarations from injector imports (#29598)

Prior to this change, a module's imports and exports would be used verbatim
as an injectors' imports. This is detrimental for tree-shaking, as a
module's exports could reference declarations that would then prevent such
declarations from being eligible for tree-shaking.

Since an injector actually only needs NgModule references as its imports,
we may safely filter out any declarations from the list of module exports.
This makes them eligible for tree-shaking once again.

PR Close #29598
This commit is contained in:
JoostK
2019-03-30 13:09:45 +01:00
committed by Jason Aden
parent 45c6360e5a
commit 2d372f48db
6 changed files with 90 additions and 11 deletions

View File

@ -73,7 +73,7 @@ export class CompilerFacadeImpl implements CompilerFacade {
type: new WrappedNodeExpr(facade.type),
deps: convertR3DependencyMetadataArray(facade.deps),
providers: new WrappedNodeExpr(facade.providers),
imports: new WrappedNodeExpr(facade.imports),
imports: facade.imports.map(i => new WrappedNodeExpr(i)),
};
const res = compileInjector(meta);
return this.jitExpression(res.expression, angularCoreEnv, sourceMapUrl, res.statements);