test: make largetable test work in g3 (#32275)

This PR modifies the `largetable` render3 (ivy) test so that it works in
g3.

1. `index.ts` must be named `index_aot.ts`
2. Scripts should be loaded via `ts_devserver` and not as an explicit
script tag in the HTML.

PR Close #32275
This commit is contained in:
Keen Yee Liau
2019-08-22 11:46:57 -07:00
committed by Misko Hevery
parent a9864471a4
commit 2d96576a10
3 changed files with 10 additions and 15 deletions

View File

@ -6,7 +6,10 @@ load("//modules/benchmarks:benchmark_test.bzl", "benchmark_test")
ng_module( ng_module(
name = "largetable_lib", name = "largetable_lib",
srcs = glob(["**/*.ts"]), srcs = [
"index_aot.ts",
"table.ts",
],
tags = ["ivy-only"], tags = ["ivy-only"],
deps = [ deps = [
"//modules/benchmarks/src:util_lib", "//modules/benchmarks/src:util_lib",
@ -14,13 +17,12 @@ ng_module(
"//packages:types", "//packages:types",
"//packages/common", "//packages/common",
"//packages/core", "//packages/core",
"@npm//reflect-metadata",
], ],
) )
ng_rollup_bundle( ng_rollup_bundle(
name = "bundle", name = "bundle",
entry_point = ":index.ts", entry_point = ":index_aot.ts",
tags = ["ivy-only"], tags = ["ivy-only"],
deps = [ deps = [
":largetable_lib", ":largetable_lib",
@ -30,12 +32,12 @@ ng_rollup_bundle(
ts_devserver( ts_devserver(
name = "devserver", name = "devserver",
static_files = [ index_html = "index.html",
":bundle.min_debug.js", port = 4200,
":bundle.min.js",
"index.html",
],
tags = ["ivy-only"], tags = ["ivy-only"],
deps = [
":bundle.min_debug.js",
],
) )
benchmark_test( benchmark_test(

View File

@ -28,12 +28,6 @@
<largetable id="root"></largetable> <largetable id="root"></largetable>
</div> </div>
<script>
// TODO(mlaval): remove once we have a proper solution
ngDevMode = false;
var bazelBundle = document.location.search.endsWith('debug') ? 'bundle.min_debug.js' : 'bundle.min.js';
document.write('<script src="' + bazelBundle + '">\u003c/script>');
</script>
</body> </body>
</html> </html>

View File

@ -5,7 +5,6 @@
* Use of this source code is governed by an MIT-style license that can be * Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import 'reflect-metadata';
import {ɵrenderComponent as renderComponent} from '@angular/core'; import {ɵrenderComponent as renderComponent} from '@angular/core';
import {bindAction, profile} from '../../util'; import {bindAction, profile} from '../../util';