From 2ea4f690e461e2e2813260c3e1fa05ae022afc12 Mon Sep 17 00:00:00 2001 From: Marc Laval Date: Tue, 5 Feb 2019 14:24:19 +0100 Subject: [PATCH] test(ivy): add root cause for failing hello world e2e tests (#28540) PR Close #28540 --- .../e2e_test/hello_world/hello_world_spec.ts | 35 ++++++++++--------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/modules/playground/e2e_test/hello_world/hello_world_spec.ts b/modules/playground/e2e_test/hello_world/hello_world_spec.ts index e64118532d..11ebe59261 100644 --- a/modules/playground/e2e_test/hello_world/hello_world_spec.ts +++ b/modules/playground/e2e_test/hello_world/hello_world_spec.ts @@ -11,29 +11,30 @@ import {browser} from 'protractor'; import {verifyNoBrowserErrors} from '../../../e2e_util/e2e_util'; -fixmeIvy('NullInjectorError: No provider for Renderer!').describe('hello world', function() { +fixmeIvy('FW-1032: Ivy doesn\'t support injecting Renderer, the deprecated renderer V1') + .describe('hello world', function() { - afterEach(verifyNoBrowserErrors); + afterEach(verifyNoBrowserErrors); - describe('hello world app', function() { - const URL = '/'; + describe('hello world app', function() { + const URL = '/'; - it('should greet', function() { - browser.get(URL); + it('should greet', function() { + browser.get(URL); + + expect(getComponentText('hello-app', '.greeting')).toEqual('hello world!'); + }); + + it('should change greeting', function() { + browser.get(URL); + + clickComponentButton('hello-app', '.changeButton'); + expect(getComponentText('hello-app', '.greeting')).toEqual('howdy world!'); + }); + }); - expect(getComponentText('hello-app', '.greeting')).toEqual('hello world!'); }); - it('should change greeting', function() { - browser.get(URL); - - clickComponentButton('hello-app', '.changeButton'); - expect(getComponentText('hello-app', '.greeting')).toEqual('howdy world!'); - }); - }); - -}); - function getComponentText(selector: string, innerSelector: string) { return browser.executeScript( `return document.querySelector("${selector}").querySelector("${innerSelector}").textContent`);