cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(language-service): bug of accessing a string index signature using dot notation (#34177)

Browse Source 
PR Close #34177
This commit is contained in:
ivanwonder
2019-12-02 15:22:07 +08:00
committed by Andrew Kushnir
parent 0d95c08cda
commit 2ebaa51514
3 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/language-service/src/typescript_symbols.ts
View File

@ -308,6 +308,10 @@ class TypeWrapper implements Symbol {
}
}
class StringIndexTypeWrappr extends TypeWrapper {
public readonly type = new TypeWrapper(this.tsType, this.context);
}
class SymbolWrapper implements Symbol {
private symbol: ts.Symbol;
private _members?: SymbolTable;
@ -506,10 +510,11 @@ class SymbolTableWrapper implements SymbolTable {
// obj.stringIndex // equivalent to obj['stringIndex'];
//
// In this case, return the type indexed by an arbitrary string key.
const symbol = this.stringIndexType.getSymbol();
if (symbol) {
return new SymbolWrapper(symbol, this.context, this.stringIndexType);
}
// if stringIndexType is js primitive type(e.g. 'string'), the Symbol is undefined;
// and In AstType.resolvePropertyRead method, the Symbol.type should get the right type.
// so I add a new Symbol type, 'StringIndexTypeWrappr'
return new StringIndexTypeWrappr(this.stringIndexType, this.context);
}
return undefined;