test(aio): remove compileComponents from all tests
By reflex we began all component tests with an async `beforeEach` that called `compileComponents`. In at least one case (`live-example.component.spec.ts`) that led to the `it` tests being async as well. There is no need to call `.compileComponents` because CLI web pack + plugin inlines all templates and styles. While `.compileComponents` was harmless, it added complexity and distraction which we should not inflict on future readers and testers.
This commit is contained in:

committed by
Pete Bacon Darwin

parent
44195858e6
commit
2ee7662737
@ -10,7 +10,7 @@ describe('ApiListComponent', () => {
|
||||
let fixture: ComponentFixture<ApiListComponent>;
|
||||
let sections: ApiSection[];
|
||||
|
||||
beforeEach(async(() => {
|
||||
beforeEach(() => {
|
||||
TestBed.configureTestingModule({
|
||||
declarations: [ ApiListComponent ],
|
||||
providers: [
|
||||
@ -18,10 +18,7 @@ describe('ApiListComponent', () => {
|
||||
{ provide: LocationService, useClass: TestLocationService }
|
||||
]
|
||||
});
|
||||
TestBed.compileComponents();
|
||||
}));
|
||||
|
||||
beforeEach(() => {
|
||||
fixture = TestBed.createComponent(ApiListComponent);
|
||||
component = fixture.componentInstance;
|
||||
sections = getApiSections();
|
||||
|
Reference in New Issue
Block a user