cargdev/angular
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases Wiki Activity

build: add npm_integration_test && angular_integration_test (#33927)

Browse Source 
* it's tricky to get out of the runfiles tree with `bazel test` as `BUILD_WORKSPACE_DIRECTORY` is not set but I employed a trick to read the `DO_NOT_BUILD_HERE` file that is one level up from `execroot` and that contains the workspace directory. This is experimental and if `bazel test //:test.debug` fails than `bazel run` is still guaranteed to work as  `BUILD_WORKSPACE_DIRECTORY` will be set in that context

* test //integration:bazel_test and //integration:bazel-schematics_test exclusively

* run "exclusive" and "manual" bazel-in-bazel integration tests in their own CI job as they take 8m+ to execute

```
//integration:bazel-schematics_test                                      PASSED in 317.2s
//integration:bazel_test                                                 PASSED in 167.8s
```

* Skip all integration tests that are now handled by angular_integration_test except the tests that are tracked for payload size; these are:
- cli-hello-world*
- hello_world__closure

* add & pin @babel deps as newer versions of babel break //packages/localize/src/tools/test:test

@babel/core dep had to be pinned to 7.6.4 or else //packages/localize/src/tools/test:test failed. Also //packages/localize uses @babel/generator, @babel/template, @babel/traverse & @babel/types so these deps were added to package.json as they were not being hoisted anymore from @babel/core transitive.

NB: integration/hello_world__systemjs_umd test must run with systemjs 0.20.0
NB: systemjs must be at 0.18.10 for legacy saucelabs job to pass
NB: With Bazel 2.0, the glob for the files to test `"integration/bazel/**"` is empty if integation/bazel is in .bazelignore. This glob worked under these conditions with 1.1.0. I did not bother testing with 1.2.x as not having integration/bazel in .bazelignore is correct.

PR Close #33927
This commit is contained in:
Greg Magolan
2020-02-04 11:45:40 -08:00
committed by Miško Hevery
parent bb09cd0e41
commit 2f572772b0
79 changed files with 7011 additions and 3750 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
integration/get-sharded-tests.js
View File

@ -24,7 +24,7 @@ const path = require('path');
const minimist = require('minimist');
// Parsed command line arguments.
const {shardIndex, maxShards} = minimist(process.argv.slice(2));
const {_, shardIndex, maxShards} = minimist(process.argv.slice(2));
// Ensure that all CLI options are set properly.
if (shardIndex == null) {
@ -32,46 +32,11 @@ if (shardIndex == null) {
} else if (maxShards == null) {
throw new Error('The "--maxShards" option has not been specified.');
}
// List of all integration tests that are available.
const integrationTests = fs.readdirSync(__dirname).filter(
testName => fs.statSync(path.join(__dirname, testName)).isDirectory());
// Manual test shards which aren't computed automatically. This is helpful when a specific
// set of integration test takes up *way* more time than all other tests, and we want to
// balance out the duration for all specific shards.
const manualTestShards = [
// The first shard should only run the bazel integration tests because these take up
// a lot of time and shouldn't be split up automatically.
['bazel', 'bazel-schematics']
];
// Tests which haven't been assigned manually to a shard. These tests will be automatically
// split across the remaining available shards.
const unassignedTests = stripManualOverrides(integrationTests, manualTestShards);
if (manualTestShards.length === maxShards && unassignedTests.length) {
throw new Error(
`Tests have been specified manually for all available shards, but there were ` +
`integration tests which haven't been specified and won't run right now. Missing ` +
`tests: ${unassignedTests.join(', ')}`)
} else if (manualTestShards.length > maxShards) {
throw new Error(
`Too many manual shards have been specified. Increase the amount of maximum shards.`);
if (shardIndex >= maxShards) {
throw new Error('shardIndex out of bounds');
}
// In case the shard for the current index has been specified manually, we just output
// the tests for the manual shard.
if (manualTestShards[shardIndex]) {
printTestNames(manualTestShards[shardIndex]);
} else {
const amountManualShards = manualTestShards.length;
// In case there isn't a manual shard specified for this shard index, we just compute the
// tests for this shard. Note that we need to subtract the amount of manual shards because
// we need to split up the unassigned tests across the remaining available shards.
printTestNames(getTestsForShardIndex(
unassignedTests, shardIndex - amountManualShards, maxShards - amountManualShards));
}
printTestNames(getTestsForShardIndex(_, shardIndex, maxShards));
/**
* Splits the specified tests into a limited amount of shards and returns the tests that should
@ -82,16 +47,6 @@ function getTestsForShardIndex(tests, shardIndex, maxShards) {
return tests.filter((n, index) => index % maxShards === shardIndex);
}
/**
* Strips all manual tests from the list of integration tests. This is necessary because
* when computing the shards automatically we don't want to include manual tests again. This
* would mean that CircleCI runs some integration tests multiple times.
*/
function stripManualOverrides(integrationTests, manualShards) {
const allManualTests = manualShards.reduce((res, manualTests) => res.concat(manualTests), []);
return integrationTests.filter(testName => !allManualTests.includes(testName))
}
/** Prints the specified test names to the stdout. */
function printTestNames(testNames) {
// Print the test names joined with spaces because this allows Bash to easily convert the output