diff --git a/aio/README.md b/aio/README.md index bf2e18a827..1370345551 100644 --- a/aio/README.md +++ b/aio/README.md @@ -30,26 +30,26 @@ Here are the most important tasks you might need to use: * `yarn docs-lint` - check that the doc gen code follows our style rules. * `yarn docs-test` - run the unit tests for the doc generation code. -* `yarn boilerplate:add` - generate all the boilerplate code for the examples, so that they can be run locally. Add the option `-- --local` to use your local version of Angular contained in the "dist" folder. +* `yarn boilerplate:add` - generate all the boilerplate code for the examples, so that they can be run locally. Add the option `--local` to use your local version of Angular contained in the "dist" folder. * `yarn boilerplate:remove` - remove all the boilerplate code that was added via `yarn boilerplate:add`. * `yarn generate-plunkers` - generate the plunker files that are used by the `live-example` tags in the docs. * `yarn generate-zips` - generate the zip files from the examples. Zip available via the `live-example` tags in the docs. * `yarn example-e2e` - run all e2e tests for examples - - `yarn example-e2e -- --setup` - force webdriver update & other setup, then run tests - - `yarn example-e2e -- --filter=foo` - limit e2e tests to those containing the word "foo" - - `yarn example-e2e -- --setup --local` - run e2e tests with the local version of Angular contained in the "dist" folder + - `yarn example-e2e --setup` - force webdriver update & other setup, then run tests + - `yarn example-e2e --filter=foo` - limit e2e tests to those containing the word "foo" + - `yarn example-e2e --setup --local` - run e2e tests with the local version of Angular contained in the "dist" folder * `yarn build-ie-polyfills` - generates a js file of polyfills that can be loaded in Internet Explorer. ## Using ServiceWorker locally -Since abb36e3cb, running `yarn start -- --prod` will no longer set up the ServiceWorker, which +Since abb36e3cb, running `yarn start --prod` will no longer set up the ServiceWorker, which would require manually running `yarn sw-manifest` and `yarn sw-copy` (something that is not possible with webpack serving the files from memory). If you want to test ServiceWorker locally, you can use `yarn build` and serve the files in `dist/` -with `yarn http-server -- dist -p 4200`. +with `yarn http-server dist -p 4200`. For more details see #16745. @@ -117,10 +117,10 @@ yarn serve-and-sync ``` * Open a browser at https://localhost:4200/ and navigate to the document on which you want to work. -You can automatically open the browser by using `yarn start -- -o` in the first terminal. +You can automatically open the browser by using `yarn start -o` in the first terminal. * Make changes to the page's associated doc or example files. Every time a file is saved, the doc will be regenerated, the app will rebuild and the page will reload. * If you get a build error complaining about examples or any other odd behavior, be sure to consult -the [Authors Style Guide](https://angular.io/guide/docs-style-guide). \ No newline at end of file +the [Authors Style Guide](https://angular.io/guide/docs-style-guide). diff --git a/aio/content/guide/docs-style-guide.md b/aio/content/guide/docs-style-guide.md index 400a2ba5d7..2006ef8ae3 100644 --- a/aio/content/guide/docs-style-guide.md +++ b/aio/content/guide/docs-style-guide.md @@ -2,13 +2,13 @@ This page presents design and layout guidelines for Angular documentation pages. These guidelines should be followed by all guide page authors. Deviations must be approved by the documentation editor. -Most guide pages should have [accompanying sample code](#from-code-samples) with -[special markup](#source-code-markup) for the code snippets on the page. -Code samples should adhere to the -[style guide for Angular applications](guide/styleguide "Application Code Style Guide") +Most guide pages should have [accompanying sample code](#from-code-samples) with +[special markup](#source-code-markup) for the code snippets on the page. +Code samples should adhere to the +[style guide for Angular applications](guide/styleguide "Application Code Style Guide") because readers expect consistency. -For clarity and precision, every guideline on _this_ page is illustrated with a working example, +For clarity and precision, every guideline on _this_ page is illustrated with a working example, followed by the page markup for that example ... as shown here. ```html @@ -19,13 +19,13 @@ followed by the page markup for that example ... as shown here. To make changes to the documentation pages and sample code, clone the [Angular github repository](https://github.com/angular/angular "Angular repo") and go to the `aio/` folder. -The [aio/README.md](https://github.com/angular/angular/blob/master/aio/README.md "AIO ReadMe") explains how to install and use the tools to edit and test your changes. +The [aio/README.md](https://github.com/angular/angular/blob/master/aio/README.md "AIO ReadMe") explains how to install and use the tools to edit and test your changes. Here are a few essential commands for guide page authors. 1. `yarn setup` — installs packages; builds docs, plunkers, and zips. -1. `yarn docs-watch -- --watch-only` — watches for saved content changes and refreshes the browser. The (optional) `--watch-only` flag skips the initial docs rebuild. +1. `yarn docs-watch --watch-only` — watches for saved content changes and refreshes the browser. The (optional) `--watch-only` flag skips the initial docs rebuild. 1. `yarn start` — starts the doc viewer application so you can see your local changes in the browser. @@ -33,9 +33,9 @@ Here are a few essential commands for guide page authors. ## Guide pages - All but a few guide pages are [markdown](https://daringfireball.net/projects/markdown/syntax "markdown") files with an `.md` extension. + All but a few guide pages are [markdown](https://daringfireball.net/projects/markdown/syntax "markdown") files with an `.md` extension. -Every guide page file is stored in the `content/guide` directory. Although the [side navigation](#navigation) panel displays as a hierarchy, the directory is flat with no sub-folders. +Every guide page file is stored in the `content/guide` directory. Although the [side navigation](#navigation) panel displays as a hierarchy, the directory is flat with no sub-folders. The flat folder approach allows us to shuffle the apparent navigation structure without moving page files or redirecting old page URLs. The doc generation process consumes the markdown files in the `content/guide` directory and produces JSON files in the `src/generated/docs/guide` directory, which is also flat. Those JSON files contain a combination of document metadata and HTML content. @@ -52,7 +52,7 @@ _Tutorial_ pages are exactly like guide pages. The only difference is that they _API_ pages are generated from Angular source code into the `src/generated/docs/api` directory. The doc viewer translates URLs that begin `api/` into requests for document JSON files in that directory. This style guide does not discuss creation or maintenance of API pages. -_Marketing_ pages are similar to guide pages. They're located in the `content/marketing` directory. While they can be markdown files, they may be static HTML pages or dynamic HTML pages that render with JSON data. +_Marketing_ pages are similar to guide pages. They're located in the `content/marketing` directory. While they can be markdown files, they may be static HTML pages or dynamic HTML pages that render with JSON data. Only a few people are authorized to write marketing pages. This style guide does not discuss creation or maintenance of marketing pages. @@ -70,14 +70,14 @@ Standard markdown processors don't allow you to put markdown _within_ HTML tags.
-**Always** follow every opening and closing HTML tag with _a blank line_. +**Always** follow every opening and closing HTML tag with _a blank line_.
```html
- **Always** follow every opening and closing HTML tag with _a blank line_. + **Always** follow every opening and closing HTML tag with _a blank line_.
``` @@ -111,7 +111,7 @@ Title text should be in "Title Case", which means that you use capital letters t ## Sections -A typical document is divided into sections. +A typical document is divided into sections. All section heading text should be in "Sentence case", which means the first word is capitalized and all other words are lower case. @@ -122,7 +122,7 @@ Main section heading There are usually one or more main sections that may be further divided into secondary sections. -Begin a main section heading with the markdown `##` characters. Alternatively, you can write the equivalent `

` HTML tag. +Begin a main section heading with the markdown `##` characters. Alternatively, you can write the equivalent `

` HTML tag. The main section heading should be followed by a blank line and then the content for that heading. @@ -164,7 +164,7 @@ Try to minimize the heading depth, preferably only two. But more headings, such Subsections typically present extra detail and references to other pages. -Use subsections for commentary that _enriches_ the reader's understanding of the text that precedes it. +Use subsections for commentary that _enriches_ the reader's understanding of the text that precedes it. A subsection _must not_ contain anything _essential_ to that understanding. Don't put a critical instruction or a tutorial step in a subsection. @@ -192,7 +192,7 @@ Note that at least one blank line must follow the opening `
`. A blank line Most pages display a table of contents (TOC). The TOC appears in the right panel when the viewport is wide. When narrow, the TOC appears in an expandable/collapsible region near the top of the page. -You should not create your own TOC by hand. The TOC is generated automatically from the page's main and secondary section headers. +You should not create your own TOC by hand. The TOC is generated automatically from the page's main and secondary section headers. To exclude a heading from the TOC, create the heading as an `

` or `

` element with a class called 'no-toc'. You can't do this with markdown. @@ -214,7 +214,7 @@ A guide without a TOC The navigation links at the top, left, and bottom of the screen are generated from the JSON configuration file, `content/navigation.json`. -The authority to change the `navigation.json` file is limited to a few core team members. +The authority to change the `navigation.json` file is limited to a few core team members. But for a new guide page, you should suggest a navigation title and position in the left-side navigation panel called the "side nav". Look for the `SideNav` node in `navigation.json`. The `SideNav` node is an array of navigation nodes. Each node is either an _item_ node for a single document or a _header_ node with child nodes. @@ -302,7 +302,7 @@ For terminal input and output, put the content between `` tags, se Inline, hand-coded snippets like this one are _not_ testable and, therefore, are intrinsically unreliable. This example belongs to the small set of pre-approved, inline snippets that includes -user input in a command shell or the _output_ of some process. +user input in a command shell or the _output_ of some process. **Do not write inline code snippets** unless you have a good reason and the editor's permission to do so. In all other cases, code snippets should be generated automatically from tested code samples. @@ -341,8 +341,8 @@ The following _code-example_ displays the sample's `app.module.ts`. Here's the brief markup that produced that lengthy snippet: ```html - ``` @@ -355,7 +355,7 @@ Following convention, you set the `title` attribute to the file's location withi
-Unless otherwise noted, all code snippets in this page are derived from sample source code +Unless otherwise noted, all code snippets in this page are derived from sample source code located in the `content/examples/docs-style-guide` directory.
@@ -377,7 +377,7 @@ The preferred way to un-ignore a file is to update the `content/examples/.gitign

-#### Code-example attributes +#### Code-example attributes You control the _code-example_ output by setting one or more of its attributes: @@ -401,8 +401,8 @@ You control the _code-example_ output by setting one or more of its attributes: Often you want to focus on a fragment of code within a sample code file. In this example, you focus on the `AppModule` class and its `NgModule` metadata. - @@ -411,8 +411,8 @@ Then you reference that _docregion_ in the `region` attribute of the ` ``` @@ -430,20 +430,20 @@ There's no need to repeat the header. Sometimes you want to display an example of bad code or bad design. -You should be careful. Readers don't always read carefully and are likely to copy and paste your example of bad code in their own applications. So don't display bad code often. +You should be careful. Readers don't always read carefully and are likely to copy and paste your example of bad code in their own applications. So don't display bad code often. When you do, set the `class` to `avoid`. The code snippet will be framed in bright red to grab the reader's attention. -Here's the markup for an "avoid" example in the +Here's the markup for an "avoid" example in the [_Angular Style Guide_](guide/styleguide#style-05-03 "Style 05-03: components as elements"). ```html - -``` +``` @@ -467,22 +467,22 @@ The next example displays multiple code tabs, each with its own title. It demonstrates control over display of line numbers at both the `` and `` levels. - - - - @@ -494,22 +494,22 @@ The `linenums` attribute in the second pane restores line numbering for _itself ```html - - - - @@ -572,8 +572,8 @@ Every line of code _after_ that comment belongs in the region _until_ the code f The `src/main.ts` is a simple example of a file with a single _#docregion_ at the top of the file. - @@ -592,8 +592,8 @@ You distinguish among them by giving each fragment its own _#docregion name_ as Remember to refer to this region by name in the `region` attribute of the `` or `` as you did in an example above like this: ```html - ``` @@ -603,7 +603,7 @@ The _#docregion_ with no name is the _default region_. Do _not_ set the `region` You can nest _#docregions_ within _#docregions_ ``` -// #docregion +// #docregion ... some code ... // #docregion inner-region ... more code ... @@ -647,12 +647,12 @@ export class AppComponent { Here's are the two corresponding code snippets displayed side-by-side. - - @@ -661,7 +661,7 @@ Here's are the two corresponding code snippets displayed side-by-side. Some observations: -* The `#docplaster` at the top is another bit of code snippet markup. It tells the processor how to join the fragments into a single snippet. +* The `#docplaster` at the top is another bit of code snippet markup. It tells the processor how to join the fragments into a single snippet. In this example, we tell the processor to put the fragments together without anything in between - without any "plaster". Most sample files define this _empty plaster_. @@ -673,7 +673,7 @@ Some observations: Code snippet markup is not supported for JSON files because comments are forbidden in JSON files. -You can display an entire JSON file by referring to it in the `src` attribute. +You can display an entire JSON file by referring to it in the `src` attribute. But you can't display JSON fragments because you can't add `#docregion` tags to the file. If the JSON file is too big, you could copy the nodes-of-interest into markdown backticks. @@ -684,12 +684,12 @@ You can't test this partial file and you'll never use it in the application. But Here's an example that excerpts certain scripts from `package.json` into a partial file named `package.1.json`. - ```html - ``` @@ -713,7 +713,7 @@ You'll find many such files among the samples in the Angular documentation. Remember to exclude these files from plunkers by listing them in the `plnkr.json` as illustrated here. - @@ -722,7 +722,7 @@ Remember to exclude these files from plunkers by listing them in the `plnkr.json By adding `` to the page you generate links that run sample code in the Plunker live coding environment and download that code to the reader's file system. -Live examples (AKA "plunkers") are defined by one or more `plnkr.json` files in the root of a code sample folder. Each sample folder usually has a single unnamed definition file, the default `plnkr.json`. +Live examples (AKA "plunkers") are defined by one or more `plnkr.json` files in the root of a code sample folder. Each sample folder usually has a single unnamed definition file, the default `plnkr.json`.
@@ -745,7 +745,7 @@ Clicking the first link opens the code sample in a new browser tab in the "embed You can change the appearance and behavior of the live example with attributes and classes. -

Custom label and tooltip

+

Custom label and tooltip

Give the live example anchor a custom label and tooltip by setting the `title` attribute. @@ -763,7 +763,7 @@ You can achieve the same effect by putting the label between the ` Live example with content label ``` -

Live example from another guide

+

Live example from another guide

To link to a plunker in a folder whose name is not the same as the current guide page, set the `name` attribute to the name of that folder. @@ -773,7 +773,7 @@ To link to a plunker in a folder whose name is not the same as the current guide Live Example from the Router guide ``` -

Live Example for named plunker

+

Live Example for named plunker

To link to a plunker defined by a named `plnkr.json` file, set the `plnkr` attribute. The following example links to the plunker defined by `second.plnkr.json` in the current guide's directory. @@ -783,7 +783,7 @@ To link to a plunker defined by a named `plnkr.json` file, set the `plnkr` attri ``` -

Live Example without download

+

Live Example without download

To skip the download link, add the `noDownload` attribute. @@ -793,7 +793,7 @@ To skip the download link, add the `noDownload` attribute. Just the plunker ``` -

Live Example with download-only

+

Live Example with download-only

To skip the live plunker link and only link to the download, add the `downloadOnly` attribute. @@ -803,9 +803,9 @@ To skip the live plunker link and only link to the download, add the `downloadOn Download only ``` -

Embedded live example

+

Embedded live example

-By default, a live example link opens a plunker in a separate browser tab. +By default, a live example link opens a plunker in a separate browser tab. You can embed the plunker within the guide page itself by adding the `embedded` attribute. For performance reasons, the plunker does not start right away. The reader sees an image instead. Clicking the image starts the sometimes-slow process of launching the embedded plunker within an iframe on the page. @@ -853,10 +853,10 @@ When navigating within the page, you can omit the page URL when specifying the l It is often a good idea to *lock-in* a good anchor name. -Sometimes the section header text makes for an unattractive anchor. [This one](#ugly-long-section-header-anchors) is pretty bad. +Sometimes the section header text makes for an unattractive anchor. [This one](#ugly-long-section-header-anchors) is pretty bad. ```html -[This one](#ugly-long-section-header-anchors) is pretty bad. +[This one](#ugly-long-section-header-anchors) is pretty bad. ``` The greater danger is that **a future rewording of the header text would break** a link to this section. @@ -922,7 +922,7 @@ A helpful, informational alert. ``` Alerts are meant to grab the user's attention and should be used sparingly. -They are not for casual asides or commentary. Use [subsections](#subsections "subsections") for commentary. +They are not for casual asides or commentary. Use [subsections](#subsections "subsections") for commentary. ## Callouts @@ -1163,9 +1163,9 @@ src="generated/images/guide/docs-style-guide/flying-hero.png" **Do not use the markdown image syntax, \!\[\.\.\.\]\(\.\.\.\).** -Images should be specified in an `` tag. +Images should be specified in an `` tag. -For accessibility, always set the `alt` attribute with a meaningful description of the image. +For accessibility, always set the `alt` attribute with a meaningful description of the image. You should nest the `` tag within a `
` tag, which styles the image within a drop-shadow frame. You'll need the editor's permission to skip the `
` tag. @@ -1177,7 +1177,7 @@ Here's a conforming example ```html
- flying hero
``` @@ -1197,13 +1197,13 @@ Here's the "flying hero" at a more reasonable scale. ```html
- flying Angular hero
``` -Wide images can be a problem. Most browsers try to rescale the image but wide images may overflow the document in certain viewports. +Wide images can be a problem. Most browsers try to rescale the image but wide images may overflow the document in certain viewports. **Do not set a width greater than 700px**. If you wish to display a larger image, provide a link to the actual image that the user can click on to see the full size image separately as in this example of `source-map-explorer` output from the "Ahead-of-time Compilation" guide: @@ -1222,11 +1222,11 @@ Consider using an image compression web site such as [tinypng](https://tinypng.c You can float the image to the left or right of text by applying the class="left" or class="right" attributes respectively. -flying Angular hero - + This text wraps around to the right of the floating "flying hero" image. Headings and code-examples automatically clear a floating image. If you need to force a piece of text to clear a floating image, add `
` where the text should break. @@ -1236,11 +1236,11 @@ Headings and code-examples automatically clear a floating image. If you need to The markup for the above example is: ```html -flying Angular hero - + This text wraps around to the right of the floating "flying hero" image. Headings and code-examples automatically clear a floating image. If you need to force a piece of text to clear a floating image, add `
` where the text should break. @@ -1256,8 +1256,8 @@ If you have a floating image inside an alert, callout, or a subsection, it is a
- flying Angular hero @@ -1268,12 +1268,12 @@ If you have a floating image inside an alert, callout, or a subsection, it is a ```html
- flying Angular hero - + A subsection with **markdown** formatted text.
-``` \ No newline at end of file +``` diff --git a/aio/package.json b/aio/package.json index 1f81dc29fa..6be9660bed 100644 --- a/aio/package.json +++ b/aio/package.json @@ -26,7 +26,7 @@ "setup-local": "yarn aio-use-local && yarn example-use-local", "postsetup-local": "yarn postsetup", "pretest-pwa-score-localhost": "yarn build", - "test-pwa-score-localhost": "concurrently --kill-others --success first \"http-server dist -p 4200 --silent\" \"yarn test-pwa-score -- http://localhost:4200 90\"", + "test-pwa-score-localhost": "concurrently --kill-others --success first \"http-server dist -p 4200 --silent\" \"yarn test-pwa-score http://localhost:4200 90\"", "test-pwa-score": "node scripts/test-pwa-score", "example-e2e": "yarn example-check-local && node ./tools/examples/run-example-e2e", "example-lint": "tslint -c \"content/examples/tslint.json\" \"content/examples/**/*.ts\" -e \"content/examples/styleguide/**/*.avoid.ts\"", diff --git a/aio/scripts/deploy-preview.sh b/aio/scripts/deploy-preview.sh index e49bd99482..5701f2a3ce 100755 --- a/aio/scripts/deploy-preview.sh +++ b/aio/scripts/deploy-preview.sh @@ -51,6 +51,6 @@ readonly relevantChangedFilesCount=$(git diff --name-only $TRAVIS_COMMIT_RANGE | # Run PWA-score tests (unless the deployment is not public yet; # i.e. it could not be automatically verified). if [[ $httpCode -ne 202 ]] && [[ "$isHidden" != "true" ]]; then - yarn test-pwa-score -- "$DEPLOYED_URL" "$MIN_PWA_SCORE" + yarn test-pwa-score "$DEPLOYED_URL" "$MIN_PWA_SCORE" fi ) diff --git a/aio/scripts/deploy-to-firebase.sh b/aio/scripts/deploy-to-firebase.sh index 90ccedd954..cdd74ce431 100755 --- a/aio/scripts/deploy-to-firebase.sh +++ b/aio/scripts/deploy-to-firebase.sh @@ -87,7 +87,7 @@ fi cd "`dirname $0`/.." # Build the app - yarn build -- --env=$deployEnv + yarn build --env=$deployEnv # Include any mode-specific files cp -rf src/extra-files/$deployEnv/. dist/ @@ -100,5 +100,5 @@ fi firebase deploy --message "Commit: $TRAVIS_COMMIT" --non-interactive --token "$firebaseToken" # Run PWA-score tests - yarn test-pwa-score -- "$deployedUrl" "$MIN_PWA_SCORE" + yarn test-pwa-score "$deployedUrl" "$MIN_PWA_SCORE" ) diff --git a/aio/tools/examples/run-example-e2e.js b/aio/tools/examples/run-example-e2e.js index f277d6b6dc..0f9ef1da75 100644 --- a/aio/tools/examples/run-example-e2e.js +++ b/aio/tools/examples/run-example-e2e.js @@ -106,7 +106,7 @@ function runE2eTests(appDir, outputFile) { const config = loadExampleConfig(appDir); const appBuildSpawnInfo = spawnExt('yarn', [config.build], { cwd: appDir }); - const appRunSpawnInfo = spawnExt('yarn', [config.run, '--', '-s'], { cwd: appDir }, true); + const appRunSpawnInfo = spawnExt('yarn', [config.run, '-s'], { cwd: appDir }, true); let run = runProtractor(appBuildSpawnInfo.promise, appDir, appRunSpawnInfo, outputFile); @@ -125,12 +125,12 @@ function runProtractor(prepPromise, appDir, appRunSpawnInfo, outputFile) { fs.appendFileSync(outputFile, emsg); return Promise.reject(emsg); }) - .then(function (data) { + .then(function () { let transpileError = false; // Start protractor. - const spawnInfo = spawnExt('yarn', ['protractor', '--', + const spawnInfo = spawnExt('yarn', ['protractor', PROTRACTOR_CONFIG_FILENAME, `--specs=${specFilename}`, '--params.appDir=' + appDir, @@ -140,19 +140,19 @@ function runProtractor(prepPromise, appDir, appRunSpawnInfo, outputFile) { spawnInfo.proc.stderr.on('data', function (data) { transpileError = transpileError || /npm ERR! Exit status 100/.test(data.toString()); }); - return spawnInfo.promise.catch(function (err) { + return spawnInfo.promise.catch(function () { if (transpileError) { const emsg = `${specFilename} failed to transpile.\n\n`; console.log(emsg); fs.appendFileSync(outputFile, emsg); } - return Promise.reject(emsg); + return Promise.reject(); }); }) .then( function () { return finish(true); }, function () { return finish(false); } - ) + ); function finish(ok) { // Ugh... proc.kill does not work properly on windows with child processes. @@ -202,7 +202,7 @@ function reportStatus(status, outputFile) { function spawnExt(command, args, options, ignoreClose = false) { let proc; const promise = new Promise((resolve, reject) => { - let descr = command + " " + args.join(' '); + let descr = command + ' ' + args.join(' '); console.log('running: ' + descr); try { proc = xSpawn.spawn(command, args, options); diff --git a/aio/tools/transforms/authors-package/watchr.js b/aio/tools/transforms/authors-package/watchr.js index debd940901..9d28225102 100644 --- a/aio/tools/transforms/authors-package/watchr.js +++ b/aio/tools/transforms/authors-package/watchr.js @@ -23,11 +23,11 @@ function next(error) { let p = Promise.resolve(); if (process.argv.indexOf('--watch-only') === -1) { - console.log('==================================================================='); + console.log('================================================================'); console.log('Running initial doc generation'); - console.log('-------------------------------------------------------------------'); - console.log('Skip the full doc-gen by running: `yarn docs-watch -- --watch-only`'); - console.log('==================================================================='); + console.log('----------------------------------------------------------------'); + console.log('Skip the full doc-gen by running: `yarn docs-watch --watch-only`'); + console.log('================================================================'); const {Dgeni} = require('dgeni'); var dgeni = new Dgeni([require('../angular.io-package')]); p = dgeni.generate(); @@ -44,4 +44,4 @@ p.then(() => { watchr.open(CONTENTS_PATH, listener, next); watchr.open(API_SOURCE_PATH, listener, next); -}); \ No newline at end of file +}); diff --git a/scripts/ci/build.sh b/scripts/ci/build.sh index fcc73831e3..3989c389dd 100755 --- a/scripts/ci/build.sh +++ b/scripts/ci/build.sh @@ -32,7 +32,7 @@ if [[ ${CI_MODE:-} == "aio" ]]; then ([[ $TRAVIS_BRANCH == "master" ]] || [[ $TRAVIS_BRANCH == $STABLE_BRANCH ]]) && [[ $TRAVIS_PULL_REQUEST != "false" ]]; then travisFoldStart "deploy.aio.pr-preview" - yarn deploy-preview -- --skip-build + yarn deploy-preview --skip-build travisFoldEnd "deploy.aio.pr-preview" fi ) diff --git a/scripts/ci/test-aio-e2e.sh b/scripts/ci/test-aio-e2e.sh index 23fb8eaefb..8d7a42bc46 100755 --- a/scripts/ci/test-aio-e2e.sh +++ b/scripts/ci/test-aio-e2e.sh @@ -13,6 +13,6 @@ source ${thisDir}/_travis-fold.sh # Run example e2e tests travisFoldStart "test.aio.example-e2e" - yarn example-e2e -- --setup --local --shard=${AIO_SHARD}/2 + yarn example-e2e --setup --local --shard=${AIO_SHARD}/2 travisFoldEnd "test.aio.example-e2e" ) diff --git a/scripts/ci/test-aio.sh b/scripts/ci/test-aio.sh index f3353d7e12..cf543c79d2 100755 --- a/scripts/ci/test-aio.sh +++ b/scripts/ci/test-aio.sh @@ -20,7 +20,7 @@ source ${thisDir}/_travis-fold.sh # Run unit tests travisFoldStart "test.aio.unit" - yarn test -- --single-run + yarn test --single-run travisFoldEnd "test.aio.unit"