cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(upgrade): update test failure cause descriptions (#27660)

Browse Source 
The changes here clarify that we now have a better description
of the root cause of the failure.

PR Close #27660
This commit is contained in:
Pete Bacon Darwin 2018-12-14 10:31:14 +00:00 committed by Miško Hevery
parent e94975d109
commit 3444aee5da
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/upgrade/test/static/integration/downgrade_component_spec.ts
View File

@ -22,7 +22,7 @@ withEachNg1Version(() => {
beforeEach(() => destroyPlatform()); beforeEach(() => destroyPlatform());
afterEach(() => destroyPlatform()); afterEach(() => destroyPlatform());
fixmeIvy('FW-716: Error: [$rootScope:inprog] $digest already in progress') fixmeIvy('FW-715: ngOnChanges being called a second time unexpectedly')
.it('should bind properties, events', async(() => { .it('should bind properties, events', async(() => {
const ng1Module = angular.module('ng1', []).run(($rootScope: angular.IScope) => { const ng1Module = angular.module('ng1', []).run(($rootScope: angular.IScope) => {
$rootScope['name'] = 'world'; $rootScope['name'] = 'world';

3
packages/upgrade/test/static/integration/upgrade_component_spec.ts
View File

@ -3336,7 +3336,8 @@ withEachNg1Version(() => {
})); }));
fixmeIvy('FW-713: ngDestroy not being called when downgraded ng2 component is destroyed') fixmeIvy(
'FW-843: destroy hooks are not registered on upgraded ng1 components contained in ng2 component templates under ivy')
.it('should call `$onDestroy()` on controller', async(() => { .it('should call `$onDestroy()` on controller', async(() => {
const controllerOnDestroyA = jasmine.createSpy('controllerOnDestroyA'); const controllerOnDestroyA = jasmine.createSpy('controllerOnDestroyA');
const controllerOnDestroyB = jasmine.createSpy('controllerOnDestroyB'); const controllerOnDestroyB = jasmine.createSpy('controllerOnDestroyB');