From 34624b2db24365d23928dd504e114c093b628b28 Mon Sep 17 00:00:00 2001 From: Tobias Bosch Date: Tue, 2 Aug 2016 07:49:33 -0700 Subject: [PATCH] refactor(core): deprecate old methods on `ApplicationRef` BREAKING CHANGE: - `ApplicationRef.run` is deprecated. Use `NgZone.run` directly - `ApplicationRef.injector` is deprecated. Inject an `Injector` or use `NgModuleRef.injector` instead - `ApplicationRef.zone` is deprecated. Inject `NgZone` instead. --- modules/@angular/core/src/application_ref.ts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/modules/@angular/core/src/application_ref.ts b/modules/@angular/core/src/application_ref.ts index d7f0f81e21..9b75ed78bf 100644 --- a/modules/@angular/core/src/application_ref.ts +++ b/modules/@angular/core/src/application_ref.ts @@ -428,6 +428,8 @@ export abstract class ApplicationRef { /** * Runs the given callback in the zone and returns the result of the callback. * Exceptions will be forwarded to the ExceptionHandler and rethrown. + * + * @deprecated Use {@link NgZone}.run instead. */ abstract run(callback: Function): any; @@ -447,11 +449,16 @@ export abstract class ApplicationRef { /** * Retrieve the application {@link Injector}. + * + * @deprecated inject an {@link Injector} directly where needed or use {@link + * NgModuleRef}.injector. */ get injector(): Injector { return unimplemented(); }; /** * Retrieve the application {@link NgZone}. + * + * @deprecated inject {@link NgZone} instead of calling this getter. */ get zone(): NgZone { return unimplemented(); }; @@ -477,8 +484,10 @@ export abstract class ApplicationRef { /** * Get a list of component types registered to this application. + * This list is populated even before the component is created. */ get componentTypes(): Type[] { return unimplemented(); }; + /** * Get a list of components registered to this application. */ @@ -539,6 +548,9 @@ export class ApplicationRef_ extends ApplicationRef { */ waitForAsyncInitializers(): Promise { return this._initStatus.donePromise; } + /** + * @deprecated + */ run(callback: Function): any { return this._zone.run( () => _callAndReportToExceptionHandler(this._exceptionHandler, callback)); @@ -593,8 +605,14 @@ export class ApplicationRef_ extends ApplicationRef { ListWrapper.remove(this._rootComponents, componentRef); } + /** + * @deprecated + */ get injector(): Injector { return this._injector; } + /** + * @deprecated + */ get zone(): NgZone { return this._zone; } tick(): void {