From 34cc3f2982d8c142e23dfcf5aae43305af3a925a Mon Sep 17 00:00:00 2001 From: Ward Bell Date: Wed, 21 Jun 2017 13:17:12 -0700 Subject: [PATCH] =?UTF-8?q?feat(aio):=20display=20=E2=80=9CSearching=20...?= =?UTF-8?q?"=20while=20building=20search=20index?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes #15923 --- .../app/search/search-results/search-results.component.html | 2 +- .../search/search-results/search-results.component.spec.ts | 6 ++++++ .../app/search/search-results/search-results.component.ts | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/aio/src/app/search/search-results/search-results.component.html b/aio/src/app/search/search-results/search-results.component.html index c2bd575b97..fedce7b829 100644 --- a/aio/src/app/search/search-results/search-results.component.html +++ b/aio/src/app/search/search-results/search-results.component.html @@ -24,5 +24,5 @@ -

No results found.

+

{{notFoundMessage}}

diff --git a/aio/src/app/search/search-results/search-results.component.spec.ts b/aio/src/app/search/search-results/search-results.component.spec.ts index 1e54faafde..eb46dd85d4 100644 --- a/aio/src/app/search/search-results/search-results.component.spec.ts +++ b/aio/src/app/search/search-results/search-results.component.spec.ts @@ -129,6 +129,11 @@ describe('SearchResultsComponent', () => { expect(component.searchAreas).toEqual([]); }); + it('should display "Searching ..." while waiting for search results', () => { + fixture.detectChanges(); + expect(getText()).toContain('Searching ...'); + }); + describe('when a search result anchor is clicked', () => { let searchResult: SearchResult; let selected: SearchResult; @@ -179,4 +184,5 @@ describe('SearchResultsComponent', () => { expect(getText()).toContain('No results'); }); }); + }); diff --git a/aio/src/app/search/search-results/search-results.component.ts b/aio/src/app/search/search-results/search-results.component.ts index adf9291985..d3e7407d68 100644 --- a/aio/src/app/search/search-results/search-results.component.ts +++ b/aio/src/app/search/search-results/search-results.component.ts @@ -21,6 +21,7 @@ export class SearchResultsComponent implements OnInit, OnDestroy { private resultsSubscription: Subscription; readonly defaultArea = 'other'; + notFoundMessage = 'Searching ...'; readonly topLevelFolders = ['guide', 'tutorial']; /** @@ -54,6 +55,7 @@ export class SearchResultsComponent implements OnInit, OnDestroy { // Map the search results into groups by area private processSearchResults(search: SearchResults) { + this.notFoundMessage = 'No results found.'; const searchAreaMap = {}; search.results.forEach(result => { if (!result.title) { return; } // bad data; should fix