cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(static_reflector): report methods with decorators in propMetadata as well

Browse Source 
This was the behavior of our regular reflector as well, although the
method name does not imply this.

Fixes #10308
Closes #10318
This commit is contained in:
Tobias Bosch
2016-07-27 02:05:07 -07:00
parent 58d9e7fc5a
commit 367f0fd142
3 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
modules/@angular/compiler-cli/test/static_reflector_spec.ts
View File

@ -7,7 +7,7 @@
*/
import {StaticReflector, StaticReflectorHost, StaticSymbol} from '@angular/compiler-cli/src/static_reflector';
import {animate, group, keyframes, sequence, state, style, transition, trigger} from '@angular/core';
import {HostListenerMetadata, animate, group, keyframes, sequence, state, style, transition, trigger} from '@angular/core';
import {beforeEach, ddescribe, describe, expect, iit, it} from '@angular/core/testing/testing_internal';
import {ListWrapper} from '@angular/facade/src/collection';
import {isBlank} from '@angular/facade/src/lang';
@ -15,6 +15,7 @@ import {MetadataCollector} from '@angular/tsc-wrapped';
import * as ts from 'typescript';
// This matches .ts files but not .d.ts files.
const TS_EXT = /(^.|(?!\.d)..)\.ts$/;
@ -94,6 +95,7 @@ describe('StaticReflector', () => {
host.findDeclaration('src/app/hero-detail.component', 'HeroDetailComponent');
let props = reflector.propMetadata(HeroDetailComponent);
expect(props['hero']).toBeTruthy();
expect(props['onMouseOver']).toEqual([new HostListenerMetadata('mouseover', ['$event'])]);
});
it('should get an empty object from propMetadata for an unknown class', () => {
@ -684,7 +686,28 @@ class MockReflectorHost implements StaticReflectorHost {
}
]
}
]
],
'onMouseOver': [
{
'__symbolic': 'method',
'decorators': [
{
'__symbolic': 'call',
'expression': {
'__symbolic': 'reference',
'module': 'angular2/src/core/metadata',
'name': 'HostListener'
},
'arguments': [
'mouseover',
[
'$event'
]
]
}
]
}
]
}
}
}