cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): complete EventEmitter in QueryList on component destroy (#18902)

Browse Source 
Fixes #18741

PR Close #18902
This commit is contained in:
Marc Laval
2017-08-28 16:07:52 +02:00
committed by Miško Hevery
parent 185a941acc
commit 36d37cc6ae
3 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/linker/query_list.ts
View File

@ -108,6 +108,12 @@ export class QueryList<T>/* implements Iterable<T> */ {
/** internal */
get dirty() { return this._dirty; }
/** internal */
destroy(): void {
this._emitter.complete();
this._emitter.unsubscribe();
}
}
function flatten<T>(list: Array<T|T[]>): T[] {

2
packages/core/src/view/view.ts
View File

@ -530,6 +530,8 @@ function destroyViewNodes(view: ViewData) {
view.renderer.destroyNode !(asElementData(view, i).renderElement);
} else if (def.flags & NodeFlags.TypeText) {
view.renderer.destroyNode !(asTextData(view, i).renderText);
} else if (def.flags & NodeFlags.TypeContentQuery || def.flags & NodeFlags.TypeViewQuery) {
asQueryList(view, i).destroy();
}
}
}