cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(aio): make githubToken mandatory for GithubApi

Browse Source
This commit is contained in:
Georgios Kalpakas
2017-02-27 22:40:13 +02:00
committed by Chuck Jazdzewski
parent c5644e5a0d
commit 37348989f0
5 changed files with 26 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
aio/aio-builds-setup/dockerbuild/scripts-js/test/common/github-api.spec.ts
View File

@ -18,18 +18,8 @@ describe('GithubApi', () => {
});
it('should log a warning if \'githubToken\' is not defined or empty', () => {
const warningMessage = 'No GitHub access-token specified. Requests will be unauthenticated.';
const consoleWarnSpy = spyOn(console, 'warn');
/* tslint:disable: no-unused-new */
new GithubApi('repo/slug');
new GithubApi('repo/slug', '');
/* tslint:enable: no-unused-new */
expect(consoleWarnSpy).toHaveBeenCalledTimes(2);
expect(consoleWarnSpy.calls.argsFor(0)[0]).toBe(warningMessage);
expect(consoleWarnSpy.calls.argsFor(1)[0]).toBe(warningMessage);
it('should throw if \'githubToken\' is missing or empty', () => {
expect(() => new GithubApi('repo/slug', '')).toThrowError('Missing or empty required parameter \'githubToken\'!');
});
});