cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "feat(compiler): allow selector-less directives as base classes (#31379)" (#32089)

Browse Source 
This reverts commit f90c7a9df0 due to breakages in G3.

PR Close #32089
This commit is contained in:
Kara Erickson
2019-08-09 18:17:09 -07:00
parent 753080133b
commit 37de490e23
5 changed files with 12 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/compiler-cli/test/ngc_spec.ts
View File

@ -2283,28 +2283,4 @@ describe('ngc transformer command-line', () => {
let exitCode = main(['-p', path.join(basePath, 'tsconfig.json')], errorSpy);
expect(exitCode).toEqual(0);
});
describe('base directives', () => {
it('should allow directives with no selector that are not in NgModules', () => {
// first only generate .d.ts / .js / .metadata.json files
writeConfig(`{
"extends": "./tsconfig-base.json",
"files": ["main.ts"]
}`);
write('main.ts', `
import {Directive} from '@angular/core';
@Directive({})
export class BaseDir {}
@Directive({})
export abstract class AbstractBaseDir {}
@Directive()
export abstract class EmptyDir {}
`);
let exitCode = main(['-p', path.join(basePath, 'tsconfig.json')], errorSpy);
expect(exitCode).toEqual(0);
});
});
});