cargdev/angular
1
0
Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "test: handle bootstrap templated_args in jasmine_node_test defaults.bzl (#34589)" (#34730)

Browse Source 
This reverts commit da4782e67f.

PR Close #34730
This commit is contained in:
atscott
2020-01-10 13:39:52 -08:00
parent bb6d033a9c
commit 38750e3f0b
61 changed files with 142 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tools/defaults.bzl
View File

@ -256,11 +256,10 @@ def nodejs_binary(data = [], **kwargs):
**kwargs
)
def jasmine_node_test(bootstrap = [], **kwargs):
def jasmine_node_test(deps = [], **kwargs):
"""Default values for jasmine_node_test"""
# Very common dependencies for tests
deps = kwargs.pop("deps", []) + [
deps = deps + [
# Very common dependencies for tests
"@npm//chokidar",
"@npm//domino",
"@npm//jasmine-core",
@ -269,18 +268,9 @@ def jasmine_node_test(bootstrap = [], **kwargs):
"@npm//tslib",
"@npm//xhr2",
]
configuration_env_vars = kwargs.pop("configuration_env_vars", []) + [
"angular_ivy_enabled",
]
templated_args = kwargs.pop("templated_args", [])
for label in bootstrap:
deps += [label]
templated_args += ["--node_options=--require=$(rlocation $(location %s))" % label]
_jasmine_node_test(
deps = deps,
configuration_env_vars = configuration_env_vars,
templated_args = templated_args,
configuration_env_vars = ["angular_ivy_enabled"],
**kwargs
)