cargdev/angular
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

test: fix typings for DoneFn (#25163)

Browse Source 
This also fixes CI tests, which were accidentally broken in #24663.

PR Close #25163
This commit is contained in:
George Kalpakas
2018-07-27 19:14:12 +03:00
committed by Igor Minar
parent 36a7705a44
commit 39abe7b7c1
9 changed files with 25 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/platform-browser-dynamic/test/testing_public_browser_spec.ts
View File

@ -104,9 +104,9 @@ class BadTemplateUrl {
reject = rej;
});
originalJasmineIt = jasmine.getEnv().it;
jasmine.getEnv().it = (description: string, fn: any /** TODO #9100 */): any => {
const done = () => { resolve(null); };
(<any>done).fail = (err: any /** TODO #9100 */) => { reject(err); };
jasmine.getEnv().it = (description: string, fn: (done: DoneFn) => void): any => {
const done = (() => resolve(null)) as DoneFn;
done.fail = reject;
fn(done);
return null;
};
@ -115,7 +115,7 @@ class BadTemplateUrl {
const restoreJasmineIt = () => { jasmine.getEnv().it = originalJasmineIt; };
it('should fail when an ResourceLoader fails', (done: any /** TODO #9100 */) => {
it('should fail when an ResourceLoader fails', done => {
const itPromise = patchJasmineIt();
it('should fail with an error from a promise', async(() => {