Revert "fix(compiler): mark NgModuleFactory construction as not side effectful (#38147)" (#38303)

This reverts commit 7f8c2225f2.

This commit caused test failures internally, which were traced back to the
optimizer removing NgModuleFactory constructor calls when those calls caused
side-effectful registration of NgModules by their ids.

PR Close #38303

packages/compiler-cli/test/ngtsc/fake_core/index.ts

@@ -103,5 +103,3 @@ export interface QueryList<T>/* implements Iterable<T> */ {
 export type NgIterable<T> = Array<T>|Iterable<T>;
 
 export class NgZone {}
-
-export declare function ɵnoSideEffects<T>(fn: () => T): T;