cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ivy): host bindings after dirs without host bindings should work (#26801)

Browse Source 
PR Close #26801
This commit is contained in:
Kara Erickson
2018-10-27 15:25:25 -07:00
parent 18b6d580c5
commit 3b9bc73db4
7 changed files with 101 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/src/render3/instructions.ts
View File

@ -14,6 +14,7 @@ import {QueryList} from '../linker';
import {Sanitizer} from '../sanitization/security';
import {StyleSanitizeFn} from '../sanitization/style_sanitizer';
import {Type} from '../type';
import {noop} from '../util/noop';
import {assertDefined, assertEqual, assertLessThan, assertNotEqual} from './assert';
import {attachPatchData, getComponentViewByInstance} from './context_discovery';
@ -41,7 +42,6 @@ import {NO_CHANGE} from './tokens';
import {getComponentViewByIndex, getNativeByIndex, getNativeByTNode, getRootContext, getRootView, getTNode, isComponent, isComponentDef, isDifferent, loadInternal, readPatchedLViewData, stringify} from './util';
/**
* A permanent marker promise which signifies that the current CD tree is
* clean.
@ -1490,7 +1490,8 @@ export function queueComponentIndexForCheck(previousOrParentTNode: TNode): void
function queueHostBindingForCheck(tView: TView, def: DirectiveDef<any>| ComponentDef<any>): void {
ngDevMode &&
assertEqual(getFirstTemplatePass(), true, 'Should only be called in first template pass.');
tView.expandoInstructions !.push(def.hostBindings !, def.hostVars);
tView.expandoInstructions !.push(def.hostBindings || noop);
if (def.hostVars) tView.expandoInstructions !.push(def.hostVars);
}
/** Caches local names and their matching directive indices for query and template lookups. */
@ -1552,7 +1553,7 @@ function baseResolveDirective<T>(
tView.blueprint.push(nodeInjectorFactory);
viewData.push(nodeInjectorFactory);
if (def.hostBindings) queueHostBindingForCheck(tView, def);
queueHostBindingForCheck(tView, def);
}
function addComponentLogic<T>(