feat(core): enable dev mode by default

BREAKING CHANGE

Before

Previously Angular would run in dev prod mode by default, and you could enable the dev mode by calling enableDevMode.

After

Now, Angular runs in the dev mode by default, and you can enable the prod mode by calling enableProdMode.
This commit is contained in:
vsavkin
2015-12-15 08:34:44 -08:00
parent de996ec50b
commit 3dca9d522a
20 changed files with 77 additions and 40 deletions

View File

@ -34,9 +34,10 @@ import {
unimplemented
} from 'angular2/src/facade/exceptions';
import {internalView} from 'angular2/src/core/linker/view_ref';
import {Console} from 'angular2/src/core/console';
import {wtfLeave, wtfCreateScope, WtfScopeFn} from './profile/profile';
import {ChangeDetectorRef} from 'angular2/src/core/change_detection/change_detector_ref';
import {lockDevMode} from 'angular2/src/facade/lang';
import {lockMode} from 'angular2/src/facade/lang';
/**
* Construct providers specific to an individual root component.
@ -98,7 +99,7 @@ var _platformProviders: any[];
* provides, Angular will throw an exception.
*/
export function platform(providers?: Array<Type | Provider | any[]>): PlatformRef {
lockDevMode();
lockMode();
if (isPresent(_platform)) {
if (ListWrapper.equals(_platformProviders, providers)) {
return _platform;
@ -425,7 +426,15 @@ export class ApplicationRef_ extends ApplicationRef {
completer.reject(e, e.stack);
}
});
return completer.promise;
return completer.promise.then(_ => {
let c = this._injector.get(Console);
let modeDescription =
assertionsEnabled() ?
"in the development mode. Call enableProdMode() to enable the production mode." :
"in the production mode. Call enableDevMode() to enable the development mode.";
c.log(`Angular 2 is running ${modeDescription}`);
return _;
});
}
/** @internal */

View File

@ -0,0 +1,7 @@
import {Injectable} from 'angular2/src/core/di';
import {print} from 'angular2/src/facade/lang';
@Injectable()
export class Console {
log(message: string): void { print(message); }
}

View File

@ -1 +0,0 @@
export {enableDevMode} from 'angular2/src/facade/lang';

View File

@ -1,5 +1,6 @@
import {Type, isBlank, isPresent, assertionsEnabled, CONST_EXPR} from 'angular2/src/facade/lang';
import {provide, Provider, Injector, OpaqueToken} from 'angular2/src/core/di';
import {Console} from 'angular2/src/core/console';
import {Reflector, reflector} from './reflection/reflection';
import {TestabilityRegistry} from 'angular2/src/core/testability/testability';
@ -10,5 +11,5 @@ function _reflector(): Reflector {
/**
* A default set of providers which should be included in any Angular platform.
*/
export const PLATFORM_COMMON_PROVIDERS: Array<Type | Provider | any[]> =
CONST_EXPR([new Provider(Reflector, {useFactory: _reflector, deps: []}), TestabilityRegistry]);
export const PLATFORM_COMMON_PROVIDERS: Array<Type | Provider | any[]> = CONST_EXPR(
[new Provider(Reflector, {useFactory: _reflector, deps: []}), TestabilityRegistry, Console]);

View File

@ -0,0 +1 @@
export {enableProdMode} from 'angular2/src/facade/lang';

View File

@ -249,23 +249,34 @@ bool isJsObject(o) {
return false;
}
bool _forceDevMode = false;
bool _devModeLocked = false;
bool _forceDevMode = true;
bool _modeLocked = false;
void lockDevMode() {
_devModeLocked = true;
void lockMode() {
_modeLocked = true;
}
@deprecated
void enableDevMode() {
if (_forceDevMode) {
return;
}
if (_devModeLocked) {
if (_modeLocked) {
throw new Exception("Cannot enable dev mode after platform setup.");
}
_forceDevMode = true;
}
void enableProdMode() {
if (_forceDevMode) {
return;
}
if (_modeLocked) {
throw new Exception("Cannot enable prod mode after platform setup.");
}
_forceDevMode = false;
}
bool assertionsEnabled() {
var k = false;
assert((k = true));

View File

@ -43,30 +43,27 @@ export function getTypeNameForDebugging(type: Type): string {
export var Math = _global.Math;
export var Date = _global.Date;
var _devMode: boolean = !!_global.angularDevMode;
var _devModeLocked: boolean = false;
var _devMode: boolean = true;
var _modeLocked: boolean = false;
export function lockDevMode() {
_devModeLocked = true;
export function lockMode() {
_modeLocked = true;
}
/**
* Enable Angular's development mode, which turns on assertions and other
* Disable Angular's development mode, which turns off assertions and other
* checks within the framework.
*
* One important assertion this enables verifies that a change detection pass
* One important assertion this disables verifies that a change detection pass
* does not result in additional changes to any bindings (also known as
* unidirectional data flow).
*
* {@example core/ts/dev_mode/dev_mode_example.ts region='enableDevMode'}
*/
export function enableDevMode() {
// TODO(alxhub): Refactor out of facade/lang as per issue #5157.
if (_devModeLocked) {
export function enableProdMode() {
if (_modeLocked) {
// Cannot use BaseException as that ends up importing from facade/lang.
throw 'Cannot enable dev mode after platform setup.';
throw 'Cannot enable prod mode after platform setup.';
}
_devMode = true;
_devMode = false;
}
export function assertionsEnabled(): boolean {