cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(platform-server): update domino to v2.1.0 (#25564)

Browse Source 
PR Close #25564
This commit is contained in:
Adam Plumer 2018-08-18 15:58:55 -05:00 committed by Kara Erickson
parent 8f0fcc3f71
commit 3fb0da2de5
5 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -80,7 +80,7 @@
"cors": "2.8.4", "cors": "2.8.4",
"dependency-graph": "^0.7.2", "dependency-graph": "^0.7.2",
"diff": "^3.5.0", "diff": "^3.5.0",
"domino": "2.0.1", "domino": "2.1.0",
"entities": "1.1.1", "entities": "1.1.1",
"firefox-profile": "1.0.3", "firefox-profile": "1.0.3",
"fs-extra": "4.0.2", "fs-extra": "4.0.2",

6
packages/core/test/render3/compiler_canonical/elements_spec.ts
View File

@ -309,7 +309,11 @@ describe('elements', () => {
} }
const comp = renderComponent(MyComponent); const comp = renderComponent(MyComponent);
expect(toHtml(comp)).toEqual('<div></div>');
// This is a fix for a change in how Domino renders this on the server in v2.1.0
const source = toHtml(comp);
const matches = source === '<div></div>' || source === '<div class=""></div>';
expect(matches).toBeTruthy();
comp.someFlag = true; comp.someFlag = true;
$r3$.ɵdetectChanges(comp); $r3$.ɵdetectChanges(comp);

2
packages/platform-server/package.json
View File

@ -21,7 +21,7 @@
"@angular/platform-browser-dynamic": "0.0.0-PLACEHOLDER" "@angular/platform-browser-dynamic": "0.0.0-PLACEHOLDER"
}, },
"dependencies": { "dependencies": {
"domino": "^2.0.1", "domino": "^2.1.0",
"tslib": "^1.9.0", "tslib": "^1.9.0",
"xhr2": "^0.1.4" "xhr2": "^0.1.4"
}, },

2
packages/platform-server/test/integration_spec.ts
View File

@ -588,7 +588,7 @@ class HiddenModule {
expect(output).toContain('Works!'); expect(output).toContain('Works!');
expect(output).toContain('ng-trigger-myAnimation'); expect(output).toContain('ng-trigger-myAnimation');
expect(output).toContain('opacity:1;'); expect(output).toContain('opacity:1;');
expect(output).toContain('transform:translate3d(0, 0, 0);'); expect(output).toContain('transform:translate3d(0 , 0 , 0);');
expect(output).toContain('font-weight:bold;'); expect(output).toContain('font-weight:bold;');
called = true; called = true;
}); });

6
yarn.lock
View File

@ -1894,9 +1894,9 @@ domain-browser@^1.1.1:
version "1.2.0" version "1.2.0"
resolved "https://registry.yarnpkg.com/domain-browser/-/domain-browser-1.2.0.tgz#3d31f50191a6749dd1375a7f522e823d42e54eda" resolved "https://registry.yarnpkg.com/domain-browser/-/domain-browser-1.2.0.tgz#3d31f50191a6749dd1375a7f522e823d42e54eda"
domino@2.0.1: domino@2.1.0:
version "2.0.1" version "2.1.0"
resolved "https://registry.yarnpkg.com/domino/-/domino-2.0.1.tgz#9e1d63215d0fe8dcb8202bff07effa1a216db504" resolved "https://registry.yarnpkg.com/domino/-/domino-2.1.0.tgz#653ba7d331441113b42e40ba05f24253ec86e02e"
dot-prop@^3.0.0: dot-prop@^3.0.0:
version "3.0.0" version "3.0.0"