cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bazel): fix the output directory for extractor to be genfiles/ instead of bin/ (#19716)

Browse Source 
PR Close #19716
This commit is contained in:
Vikram Subramanian 2017-10-13 16:19:24 -07:00 committed by Tobias Bosch
parent 836c889baa
commit 405ccc7195
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/bazel/src/ng_module.bzl
View File

@ -50,7 +50,7 @@ def _expected_outs(ctx, label):
declaration_files += [ctx.new_file(ctx.bin_dir, basename + ext) for ext in declarations] declaration_files += [ctx.new_file(ctx.bin_dir, basename + ext) for ext in declarations]
summary_files += [ctx.new_file(ctx.bin_dir, basename + ext) for ext in summaries] summary_files += [ctx.new_file(ctx.bin_dir, basename + ext) for ext in summaries]
i18n_messages_files = [ctx.new_file(ctx.bin_dir, ctx.label.name + "_ngc_messages.xmb")] i18n_messages_files = [ctx.new_file(ctx.genfiles_dir, ctx.label.name + "_ngc_messages.xmb")]
return struct( return struct(
closure_js = closure_js_files, closure_js = closure_js_files,
@ -144,7 +144,10 @@ def ngc_compile_action(ctx, label, inputs, outputs, messages_out, config_file_pa
executable = ctx.executable._ng_xi18n, executable = ctx.executable._ng_xi18n,
arguments = (_EXTRA_NODE_OPTIONS_FLAGS + arguments = (_EXTRA_NODE_OPTIONS_FLAGS +
[config_file_path] + [config_file_path] +
[messages_out[0].short_path]), # The base path is bin_dir because of the way the ngc
# compiler host is configured. So we need to explictily
# point to genfiles/ to redirect the output.
["../genfiles/" + messages_out[0].short_path]),
progress_message = "Extracting Angular 2 messages (ng_xi18n)", progress_message = "Extracting Angular 2 messages (ng_xi18n)",
mnemonic = "Angular2MessageExtractor") mnemonic = "Angular2MessageExtractor")