From 417683226642a8248eb9d358b8930d52cd9a6c99 Mon Sep 17 00:00:00 2001 From: Chuck Jazdzewski Date: Wed, 2 Aug 2017 17:32:02 -0700 Subject: [PATCH] refactor(router): compile router cleanly with TypeScript 2.4 (#18465) --- packages/router/src/router.ts | 2 +- packages/router/src/utils/collection.ts | 2 +- packages/router/test/config.spec.ts | 2 +- packages/router/test/integration.spec.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/router/src/router.ts b/packages/router/src/router.ts index a3d1b65e43..5dc7177933 100644 --- a/packages/router/src/router.ts +++ b/packages/router/src/router.ts @@ -537,7 +537,7 @@ export class Router { let resolve: any = null; let reject: any = null; - const promise = new Promise((res, rej) => { + const promise = new Promise((res, rej) => { resolve = res; reject = rej; }); diff --git a/packages/router/src/utils/collection.ts b/packages/router/src/utils/collection.ts index b96cadb1de..95ac0703f5 100644 --- a/packages/router/src/utils/collection.ts +++ b/packages/router/src/utils/collection.ts @@ -103,5 +103,5 @@ export function wrapIntoObservable(value: T | NgModuleFactory| Promise| return fromPromise(Promise.resolve(value)); } - return of (value); + return of (value as T); } diff --git a/packages/router/test/config.spec.ts b/packages/router/test/config.spec.ts index ad643a8fae..9ef3037c69 100644 --- a/packages/router/test/config.spec.ts +++ b/packages/router/test/config.spec.ts @@ -45,7 +45,7 @@ describe('config', () => { expect(() => { validateConfig([ {path: 'a', component: ComponentA}, - [{path: 'b', component: ComponentB}, {path: 'c', component: ComponentC}] + [{path: 'b', component: ComponentB}, {path: 'c', component: ComponentC}] as any ]); }).toThrowError(`Invalid configuration of route '': Array cannot be specified`); }); diff --git a/packages/router/test/integration.spec.ts b/packages/router/test/integration.spec.ts index a9b3dba3f2..eeb5fce0cb 100644 --- a/packages/router/test/integration.spec.ts +++ b/packages/router/test/integration.spec.ts @@ -1820,7 +1820,7 @@ describe('Integration', () => { function delayPromise(delay: number): Promise { let resolve: (val: boolean) => void; - const promise = new Promise(res => resolve = res); + const promise = new Promise(res => resolve = res); setTimeout(() => resolve(true), delay); return promise; }