From 41de05e1ae8d71cedd865ae0cd9b45b01610ee68 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Tue, 26 Feb 2019 22:41:49 +0100 Subject: [PATCH] test(ivy): update select root causes (#28989) Updates the root causes for the `MatSelect` failures. A few of them were fixed by https://github.com/angular/material2/pull/15320. PR Close #28989 --- .../angular_material_test_blocklist.js | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/tools/material-ci/angular_material_test_blocklist.js b/tools/material-ci/angular_material_test_blocklist.js index 386edcb4cf..59fc89b18b 100644 --- a/tools/material-ci/angular_material_test_blocklist.js +++ b/tools/material-ci/angular_material_test_blocklist.js @@ -649,29 +649,13 @@ window.testBlocklist = { "error": "TypeError: Cannot read property 'componentInstance' of null", "notes": "FW-1059: DebugNode.query should query nodes in the logical tree" }, - "MatSelect core overlay panel should not throw when attempting to open too early": { - "error": "Error: Expected function not to throw, but it threw TypeError: Cannot read property 'open' of undefined.", - "notes": "Unknown" - }, - "MatSelect core selection logic should handle accessing `optionSelectionChanges` before the options are initialized": { - "error": "TypeError: Cannot read property 'options' of undefined", - "notes": "Unknown" - }, - "MatSelect core keyboard scrolling should skip option group labels": { - "error": "ObjectUnsubscribedError: object unsubscribed", - "notes": "Unknown" - }, "MatSelect when the select's value is accessed on initialization should not throw when trying to access the selected value on init": { "error": "Error: Expected function not to throw, but it threw TypeError: Cannot read property 'selected' of undefined.", - "notes": "Unknown" - }, - "MatSelect with custom value accessor should support use inside a custom value accessor": { - "error": "Error: : could not find an object to spy upon for writeValue()", - "notes": "Unknown" + "notes": "FW-1051: Property values changed in ngOnChanges throw ExpressionChanged errors" }, "MatSelect with custom trigger should allow the user to customize the label": { "error": "TypeError: Cannot read property 'selected' of undefined", - "notes": "Unknown" + "notes": "FW-1051: Property values changed in ngOnChanges throw ExpressionChanged errors" }, "MatSnackBar with TemplateRef should be able to open a snack bar using a TemplateRef": { "error": "Error: Expected ' Fries Pizza ' to contain 'Pasta'.",