test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)
We are close enough to blacklist a few test targets, rather than whitelist targets to run... Because bazel rules can be composed of other rules that don't inherit tags automatically, I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and "ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even if those targets are composed of other targets that don't inherit this tag. This is the updated overview of ivy related bazel tags: - ivy-only: target that builds or runs only under ivy - fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit - fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local - no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit - no-ivy-local: target that is not intended to build or run under ivy with --compile=local PR Close #26471
This commit is contained in:

committed by
Alex Rickabaugh

parent
361eaf1888
commit
4237c34c78
@ -26,6 +26,7 @@ def rules_angular_dependencies():
|
||||
name = "build_bazel_rules_typescript",
|
||||
url = "https://github.com/bazelbuild/rules_typescript/archive/0.20.3.zip",
|
||||
strip_prefix = "rules_typescript-0.20.3",
|
||||
sha256 = "2a03b23c30c5109ab0863cfa60acce73ceb56337d41efc2dd67f8455a1c1d5f3",
|
||||
)
|
||||
|
||||
# Needed for Remote Execution
|
||||
|
@ -36,6 +36,7 @@ def rules_typescript_dependencies():
|
||||
http_archive,
|
||||
name = "build_bazel_rules_nodejs",
|
||||
urls = ["https://github.com/bazelbuild/rules_nodejs/archive/0.15.1.zip"],
|
||||
sha256 = "a0a91a2e0cee32e9304f1aeea9e6c1b611afba548058c5980217d44ee11e3dd7",
|
||||
strip_prefix = "rules_nodejs-0.15.1",
|
||||
)
|
||||
|
||||
|
@ -24,6 +24,10 @@ jasmine_node_test(
|
||||
"@ngdeps//@types/shelljs",
|
||||
"@ngdeps//shelljs",
|
||||
],
|
||||
tags = [
|
||||
"fixme-ivy-local",
|
||||
"no-ivy-jit",
|
||||
],
|
||||
)
|
||||
|
||||
ts_library(
|
||||
@ -65,6 +69,7 @@ jasmine_node_test(
|
||||
# TODO(alexeagle): re-enable this test
|
||||
# see https://github.com/angular/angular/pull/22933
|
||||
tags = ["manual"],
|
||||
deps = ["@ngdeps//diff"],
|
||||
)
|
||||
|
||||
nodejs_binary(
|
||||
|
@ -33,4 +33,5 @@ jasmine_node_test(
|
||||
"//packages/bazel/test/ngc-wrapped/empty:tsconfig.json",
|
||||
"@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto",
|
||||
],
|
||||
tags = ["fixme-ivy-local"],
|
||||
)
|
||||
|
@ -5,6 +5,7 @@ package(default_visibility = ["//packages/bazel/test:__subpackages__"])
|
||||
ng_module(
|
||||
name = "empty",
|
||||
srcs = ["empty.ts"],
|
||||
tags = ["fixme-ivy-local"],
|
||||
tsconfig = ":tsconfig.json",
|
||||
deps = [
|
||||
"//packages/core",
|
||||
|
@ -8,8 +8,6 @@ ts_library(
|
||||
name = "app",
|
||||
srcs = ["app.ts"],
|
||||
tsconfig = ":tsconfig.json",
|
||||
# FIXME: should not be needed here!
|
||||
deps = ["@ngdeps//@types/jasmine"],
|
||||
)
|
||||
|
||||
ts_devserver(
|
||||
@ -37,7 +35,7 @@ ts_library(
|
||||
name = "ts_spec",
|
||||
testonly = True,
|
||||
srcs = ["test.spec.ts"],
|
||||
tsconfig = ":tsconfig.json",
|
||||
tsconfig = ":tsconfig.test.json",
|
||||
deps = [
|
||||
"@ngdeps//@types/selenium-webdriver",
|
||||
"@ngdeps//protractor",
|
||||
|
@ -1,6 +1,6 @@
|
||||
{
|
||||
"compilerOptions": {
|
||||
"lib": ["dom", "es2015"],
|
||||
"types": ["jasmine"]
|
||||
"types": []
|
||||
}
|
||||
}
|
||||
|
6
packages/bazel/test/protractor-2/tsconfig.test.json
Normal file
6
packages/bazel/test/protractor-2/tsconfig.test.json
Normal file
@ -0,0 +1,6 @@
|
||||
{
|
||||
"extends": "./tsconfig.json",
|
||||
"compilerOptions": {
|
||||
"types": ["jasmine"]
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user