test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)

We are close enough to blacklist a few test targets, rather than whitelist targets to run...

Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.

This is the updated overview of ivy related bazel tags:

- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local

PR Close #26471
This commit is contained in:
Igor Minar
2018-10-15 23:24:22 -07:00
committed by Alex Rickabaugh
parent 361eaf1888
commit 4237c34c78
79 changed files with 347 additions and 172 deletions

View File

@ -22,8 +22,6 @@ ng_package(
entry_point = "packages/compiler/compiler.js",
include_devmode_srcs = True,
tags = [
"ivy-jit",
"ivy-local",
"release-with-framework",
],
deps = [

View File

@ -28,7 +28,7 @@ ts_library(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(
["**/*.ts"],
exclude = NODE_ONLY + UTILS,
@ -49,7 +49,7 @@ ts_library(
ts_library(
name = "test_node_only_lib",
testonly = 1,
testonly = True,
srcs = glob(
NODE_ONLY,
exclude = UTILS,
@ -74,6 +74,10 @@ jasmine_node_test(
"//packages/common:npm_package",
"//packages/core:npm_package",
],
tags = [
"fixme-ivy-jit",
"fixme-ivy-local",
],
deps = [
":test_lib",
":test_node_only_lib",
@ -86,6 +90,10 @@ jasmine_node_test(
ts_web_test_suite(
name = "test_web",
tags = [
"fixme-ivy-jit",
"fixme-ivy-local",
],
deps = [
":test_lib",
],

View File

@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "ts_library")
ts_library(
name = "utils",
testonly = 1,
testonly = True,
srcs = glob(
["*.ts"],
),

View File

@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(
["**/*.ts"],
),