test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)

We are close enough to blacklist a few test targets, rather than whitelist targets to run... Because bazel rules can be composed of other rules that don't inherit tags automatically, I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and "ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even if those targets are composed of other targets that don't inherit this tag. This is the updated overview of ivy related bazel tags: - ivy-only: target that builds or runs only under ivy - fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit - fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local - no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit - no-ivy-local: target that is not intended to build or run under ivy with --compile=local PR Close #26471
2018-10-15 23:24:22 -07:00
parent 361eaf1888
commit 4237c34c78
79 changed files with 347 additions and 172 deletions
--- a/packages/compiler-cli/BUILD.bazel
+++ b/packages/compiler-cli/BUILD.bazel
@ -44,8 +44,6 @@ npm_package(
        "package.json",
    ],
    tags = [
-        "ivy-jit",
-        "ivy-local",
        "release-with-framework",
    ],
    deps = [
--- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel
+++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/BUILD.bazel
@ -4,12 +4,17 @@ load("//tools:defaults.bzl", "ng_module", "ts_library")

 ng_module(
    name = "app",
+    testonly = True,
    srcs = glob(
        [
            "src/**/*.ts",
        ],
    ),
    module_name = "app_built",
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        "//packages/compiler-cli/integrationtest/bazel/injectable_def/lib2",
        "//packages/core",
--- a/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel
+++ b/packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel
@ -4,12 +4,16 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(
        [
            "**/*.ts",
        ],
    ),
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        "//packages/compiler-cli/integrationtest/bazel/injectable_def/app",
        "//packages/core",
@ -21,6 +25,10 @@ ts_library(
 jasmine_node_test(
    name = "test",
    bootstrap = ["angular/tools/testing/init_node_spec.js"],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":test_lib",
        "//packages/platform-server",
--- a/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel
+++ b/packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(
        [
            "**/*.ts",
@ -19,6 +19,10 @@ ts_library(
 jasmine_node_test(
    name = "test",
    bootstrap = ["angular/tools/testing/init_node_spec.js"],
+    tags = [
+        "fixme-ivy-jit",
+        "fixme-ivy-local",
+    ],
    deps = [
        ":test_lib",
        "//tools/testing:node",
--- a/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel
+++ b/packages/compiler-cli/integrationtest/bazel/ng_module/BUILD.bazel
@ -28,4 +28,8 @@ jasmine_node_test(
    name = "test",
    srcs = ["spec.js"],
    data = [":flat_module_index"],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
 )
--- a/packages/compiler-cli/src/ngcc/test/BUILD.bazel
+++ b/packages/compiler-cli/src/ngcc/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel
+++ b/packages/compiler-cli/src/ngtsc/annotations/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel
+++ b/packages/compiler-cli/src/ngtsc/metadata/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel
+++ b/packages/compiler-cli/src/ngtsc/testing/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "ts_library")

 ts_library(
    name = "testing",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/src/ngtsc/typecheck/test/BUILD.bazel
+++ b/packages/compiler-cli/src/ngtsc/typecheck/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel
+++ b/packages/compiler-cli/src/ngtsc/util/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*.ts",
    ]),
--- a/packages/compiler-cli/test/BUILD.bazel
+++ b/packages/compiler-cli/test/BUILD.bazel
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_utils",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "mocks.ts",
        "test_support.ts",
@ -24,7 +24,7 @@ ts_library(
 # extract_18n_spec
 ts_library(
    name = "extract_i18n_lib",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "extract_i18n_spec.ts",
    ],
@ -42,6 +42,10 @@ jasmine_node_test(
    data = [
        "//packages/core:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":extract_i18n_lib",
        "//packages/common:npm_package",
@ -54,7 +58,7 @@ jasmine_node_test(
 # ngc_spec
 ts_library(
    name = "ngc_lib",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "ngc_spec.ts",
    ],
@ -76,6 +80,10 @@ jasmine_node_test(
        "//packages/platform-browser:npm_package",
        "//packages/router:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":ngc_lib",
        "//packages/core",
@ -88,7 +96,7 @@ jasmine_node_test(
 # ngctools_api_spec
 ts_library(
    name = "ngtools_api_lib",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "ngtools_api_spec.ts",
    ],
@ -107,6 +115,10 @@ jasmine_node_test(
        "//packages/core:npm_package",
        "//packages/router:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":ngtools_api_lib",
        "//packages/core",
@ -117,7 +129,7 @@ jasmine_node_test(
 # perform_watch_spec
 ts_library(
    name = "perform_watch_lib",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "perform_watch_spec.ts",
    ],
@ -145,7 +157,7 @@ jasmine_node_test(
 # perform_compile_spec
 ts_library(
    name = "perform_compile_lib",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "perform_compile_spec.ts",
    ],
--- a/packages/compiler-cli/test/compliance/BUILD.bazel
+++ b/packages/compiler-cli/test/compliance/BUILD.bazel
@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(
        ["**/*.ts"],
    ),
@ -22,7 +22,6 @@ jasmine_node_test(
        "//packages/compiler-cli/test/ngtsc/fake_core:npm_package",
    ],
    tags = [
-        "ivy-local",
        "ivy-only",
    ],
    deps = [
--- a/packages/compiler-cli/test/diagnostics/BUILD.bazel
+++ b/packages/compiler-cli/test/diagnostics/BUILD.bazel
@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "mocks",
-    testonly = 1,
+    testonly = True,
    srcs = [
        "mocks.ts",
    ],
@ -19,7 +19,7 @@ ts_library(
 # check_types_spec
 ts_library(
    name = "check_types_lib",
-    testonly = 1,
+    testonly = True,
    srcs = ["check_types_spec.ts"],
    deps = [
        ":mocks",
@ -37,6 +37,10 @@ jasmine_node_test(
        "//packages/common:npm_package",
        "//packages/core:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":check_types_lib",
        "//packages/core",
@ -47,7 +51,7 @@ jasmine_node_test(
 # expression_diagnostics_spec
 ts_library(
    name = "expression_diagnostics_lib",
-    testonly = 1,
+    testonly = True,
    srcs = ["expression_diagnostics_spec.ts"],
    deps = [
        ":mocks",
@ -67,6 +71,10 @@ jasmine_node_test(
        "//packages/core:npm_package",
        "//packages/forms:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":expression_diagnostics_lib",
        "//packages/core",
@ -77,7 +85,7 @@ jasmine_node_test(
 # typescript_symbols_spec
 ts_library(
    name = "typescript_symbols_lib",
-    testonly = 1,
+    testonly = True,
    srcs = ["typescript_symbols_spec.ts"],
    deps = [
        ":mocks",
@ -105,7 +113,7 @@ jasmine_node_test(
 # typescript_version_spec
 ts_library(
    name = "typescript_version_lib",
-    testonly = 1,
+    testonly = True,
    srcs = ["typescript_version_spec.ts"],
    deps = [
        "//packages/compiler-cli",
--- a/packages/compiler-cli/test/metadata/BUILD.bazel
+++ b/packages/compiler-cli/test/metadata/BUILD.bazel
@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(["**/*.ts"]),
    deps = [
        "//packages:types",
--- a/packages/compiler-cli/test/ngcc/BUILD.bazel
+++ b/packages/compiler-cli/test/ngcc/BUILD.bazel
@ -3,7 +3,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
 # Integration tests
 ts_library(
    name = "ngcc_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob([
        "**/*_spec.ts",
    ]),
--- a/packages/compiler-cli/test/ngtsc/BUILD.bazel
+++ b/packages/compiler-cli/test/ngtsc/BUILD.bazel
@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "ngtsc_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(["**/*.ts"]),
    deps = [
        "//packages/compiler",
--- a/packages/compiler-cli/test/transformers/BUILD.bazel
+++ b/packages/compiler-cli/test/transformers/BUILD.bazel
@ -2,7 +2,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")

 ts_library(
    name = "test_lib",
-    testonly = 1,
+    testonly = True,
    srcs = glob(["**/*.ts"]),
    deps = [
        "//packages:types",
@ -25,6 +25,10 @@ jasmine_node_test(
        "//packages/core:npm_package",
        "//packages/router:npm_package",
    ],
+    tags = [
+        "fixme-ivy-local",
+        "no-ivy-jit",
+    ],
    deps = [
        ":test_lib",
        "//packages/core",