test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)

We are close enough to blacklist a few test targets, rather than whitelist targets to run...

Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.

This is the updated overview of ivy related bazel tags:

- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local

PR Close #26471
This commit is contained in:
Igor Minar
2018-10-15 23:24:22 -07:00
committed by Alex Rickabaugh
parent 361eaf1888
commit 4237c34c78
79 changed files with 347 additions and 172 deletions

View File

@ -4,12 +4,17 @@ load("//tools:defaults.bzl", "ng_module", "ts_library")
ng_module(
name = "app",
testonly = True,
srcs = glob(
[
"src/**/*.ts",
],
),
module_name = "app_built",
tags = [
"fixme-ivy-local",
"no-ivy-jit",
],
deps = [
"//packages/compiler-cli/integrationtest/bazel/injectable_def/lib2",
"//packages/core",

View File

@ -4,12 +4,16 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(
[
"**/*.ts",
],
),
tags = [
"fixme-ivy-local",
"no-ivy-jit",
],
deps = [
"//packages/compiler-cli/integrationtest/bazel/injectable_def/app",
"//packages/core",
@ -21,6 +25,10 @@ ts_library(
jasmine_node_test(
name = "test",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
tags = [
"fixme-ivy-local",
"no-ivy-jit",
],
deps = [
":test_lib",
"//packages/platform-server",

View File

@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(
[
"**/*.ts",
@ -19,6 +19,10 @@ ts_library(
jasmine_node_test(
name = "test",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
tags = [
"fixme-ivy-jit",
"fixme-ivy-local",
],
deps = [
":test_lib",
"//tools/testing:node",

View File

@ -28,4 +28,8 @@ jasmine_node_test(
name = "test",
srcs = ["spec.js"],
data = [":flat_module_index"],
tags = [
"fixme-ivy-local",
"no-ivy-jit",
],
)