test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)
We are close enough to blacklist a few test targets, rather than whitelist targets to run... Because bazel rules can be composed of other rules that don't inherit tags automatically, I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and "ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even if those targets are composed of other targets that don't inherit this tag. This is the updated overview of ivy related bazel tags: - ivy-only: target that builds or runs only under ivy - fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit - fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local - no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit - no-ivy-local: target that is not intended to build or run under ivy with --compile=local PR Close #26471
This commit is contained in:

committed by
Alex Rickabaugh

parent
361eaf1888
commit
4237c34c78
@ -4,13 +4,11 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_sui
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(
|
||||
["**/*.ts"],
|
||||
exclude = [
|
||||
"**/*_node_only_spec.ts",
|
||||
"render3/**/*.ts",
|
||||
"ivy_local_empty_spec.ts",
|
||||
],
|
||||
),
|
||||
deps = [
|
||||
@ -35,18 +33,9 @@ ts_library(
|
||||
],
|
||||
)
|
||||
|
||||
ts_library(
|
||||
name = "ivy_local_empty_lib",
|
||||
testonly = 1,
|
||||
srcs = ["ivy_local_empty_spec.ts"],
|
||||
deps = [
|
||||
"//packages:types",
|
||||
],
|
||||
)
|
||||
|
||||
ts_library(
|
||||
name = "test_node_only_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["**/*_node_only_spec.ts"]),
|
||||
deps = [
|
||||
":test_lib",
|
||||
@ -62,6 +51,10 @@ ts_library(
|
||||
jasmine_node_test(
|
||||
name = "test",
|
||||
bootstrap = ["angular/tools/testing/init_node_spec.js"],
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
":test_node_only_lib",
|
||||
@ -74,21 +67,12 @@ jasmine_node_test(
|
||||
],
|
||||
)
|
||||
|
||||
jasmine_node_test(
|
||||
name = "ivy_local_empty_test",
|
||||
bootstrap = ["angular/tools/testing/init_node_no_angular_spec.js"],
|
||||
tags = [
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
deps = [
|
||||
":ivy_local_empty_lib",
|
||||
"//tools/testing:node_no_angular",
|
||||
],
|
||||
)
|
||||
|
||||
ts_web_test_suite(
|
||||
name = "test_web",
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
],
|
||||
|
@ -37,7 +37,6 @@ js_expected_symbol_test(
|
||||
src = ":bundle.min_debug.js",
|
||||
golden = ":bundle.golden_symbols.json",
|
||||
tags = [
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
)
|
||||
|
@ -31,7 +31,7 @@ ng_rollup_bundle(
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["*_spec.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
@ -49,8 +49,6 @@ jasmine_node_test(
|
||||
":bundle.min_debug.js",
|
||||
],
|
||||
tags = [
|
||||
"ivy-jit",
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
deps = [":test_lib"],
|
||||
@ -61,7 +59,6 @@ js_expected_symbol_test(
|
||||
src = ":bundle.min_debug.js",
|
||||
golden = ":bundle.golden_symbols.json",
|
||||
tags = [
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
)
|
||||
|
@ -31,7 +31,7 @@ ng_rollup_bundle(
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["*_spec.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
|
@ -31,7 +31,7 @@ ng_rollup_bundle(
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["*_spec.ts"]),
|
||||
deps = [
|
||||
":injection",
|
||||
|
@ -37,7 +37,7 @@ ng_rollup_bundle(
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["*_spec.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
@ -56,8 +56,6 @@ jasmine_node_test(
|
||||
":bundle.min_debug.js",
|
||||
],
|
||||
tags = [
|
||||
"ivy-jit",
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
deps = [":test_lib"],
|
||||
@ -68,7 +66,6 @@ js_expected_symbol_test(
|
||||
src = ":bundle.min_debug.js",
|
||||
golden = ":bundle.golden_symbols.json",
|
||||
tags = [
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
)
|
||||
|
@ -41,7 +41,7 @@ ng_rollup_bundle(
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["*_spec.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
@ -62,8 +62,6 @@ jasmine_node_test(
|
||||
":bundle.min_debug.js",
|
||||
],
|
||||
tags = [
|
||||
"ivy-jit",
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
deps = [":test_lib"],
|
||||
@ -74,7 +72,6 @@ js_expected_symbol_test(
|
||||
src = ":bundle.min_debug.js",
|
||||
golden = ":bundle.golden_symbols.json",
|
||||
tags = [
|
||||
"ivy-local",
|
||||
"ivy-only",
|
||||
],
|
||||
)
|
||||
|
@ -1,19 +0,0 @@
|
||||
/**
|
||||
* @license
|
||||
* Copyright Google Inc. All Rights Reserved.
|
||||
*
|
||||
* Use of this source code is governed by an MIT-style license that can be
|
||||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
/*
|
||||
* This file exists to have at least one test target that can pass with --define=compile=local.
|
||||
*
|
||||
* TODO(alxhub): Clean up once actual Angular tests start passing with Ivy/AOT.
|
||||
*/
|
||||
|
||||
describe('empty test', () => {
|
||||
it('should pass without doing anything', () => {
|
||||
// If this fails, you probably need a new computer.
|
||||
});
|
||||
});
|
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_sui
|
||||
|
||||
ts_library(
|
||||
name = "render3_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(
|
||||
["**/*.ts"],
|
||||
exclude = [
|
||||
@ -32,7 +32,7 @@ ts_library(
|
||||
|
||||
ts_library(
|
||||
name = "domino",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = [
|
||||
"domino.d.ts",
|
||||
"load_domino.ts",
|
||||
@ -46,7 +46,7 @@ ts_library(
|
||||
|
||||
ts_library(
|
||||
name = "render3_node_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = [],
|
||||
deps = [
|
||||
":domino",
|
||||
@ -59,6 +59,10 @@ jasmine_node_test(
|
||||
bootstrap = [
|
||||
"angular/packages/core/test/render3/load_domino",
|
||||
],
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":render3_node_lib",
|
||||
"@ngdeps//zone.js",
|
||||
@ -67,6 +71,10 @@ jasmine_node_test(
|
||||
|
||||
ts_web_test_suite(
|
||||
name = "render3_web",
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":render3_lib",
|
||||
],
|
||||
|
@ -4,7 +4,7 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_sui
|
||||
|
||||
ts_library(
|
||||
name = "ivy_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["**/*.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
|
Reference in New Issue
Block a user