test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)

We are close enough to blacklist a few test targets, rather than whitelist targets to run...

Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.

This is the updated overview of ivy related bazel tags:

- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local

PR Close #26471
This commit is contained in:
Igor Minar
2018-10-15 23:24:22 -07:00
committed by Alex Rickabaugh
parent 361eaf1888
commit 4237c34c78
79 changed files with 347 additions and 172 deletions

View File

@ -4,13 +4,11 @@ load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_sui
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(
["**/*.ts"],
exclude = [
"**/*_node_only_spec.ts",
"render3/**/*.ts",
"ivy_local_empty_spec.ts",
],
),
deps = [
@ -35,18 +33,9 @@ ts_library(
],
)
ts_library(
name = "ivy_local_empty_lib",
testonly = 1,
srcs = ["ivy_local_empty_spec.ts"],
deps = [
"//packages:types",
],
)
ts_library(
name = "test_node_only_lib",
testonly = 1,
testonly = True,
srcs = glob(["**/*_node_only_spec.ts"]),
deps = [
":test_lib",
@ -62,6 +51,10 @@ ts_library(
jasmine_node_test(
name = "test",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
tags = [
"fixme-ivy-jit",
"fixme-ivy-local",
],
deps = [
":test_lib",
":test_node_only_lib",
@ -74,21 +67,12 @@ jasmine_node_test(
],
)
jasmine_node_test(
name = "ivy_local_empty_test",
bootstrap = ["angular/tools/testing/init_node_no_angular_spec.js"],
tags = [
"ivy-local",
"ivy-only",
],
deps = [
":ivy_local_empty_lib",
"//tools/testing:node_no_angular",
],
)
ts_web_test_suite(
name = "test_web",
tags = [
"fixme-ivy-jit",
"fixme-ivy-local",
],
deps = [
":test_lib",
],