test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)

We are close enough to blacklist a few test targets, rather than whitelist targets to run...

Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.

This is the updated overview of ivy related bazel tags:

- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local

PR Close #26471
This commit is contained in:
Igor Minar
2018-10-15 23:24:22 -07:00
committed by Alex Rickabaugh
parent 361eaf1888
commit 4237c34c78
79 changed files with 347 additions and 172 deletions

View File

@ -37,7 +37,6 @@ js_expected_symbol_test(
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-local",
"ivy-only",
],
)

View File

@ -31,7 +31,7 @@ ng_rollup_bundle(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(["*_spec.ts"]),
deps = [
"//packages:types",
@ -49,8 +49,6 @@ jasmine_node_test(
":bundle.min_debug.js",
],
tags = [
"ivy-jit",
"ivy-local",
"ivy-only",
],
deps = [":test_lib"],
@ -61,7 +59,6 @@ js_expected_symbol_test(
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-local",
"ivy-only",
],
)

View File

@ -31,7 +31,7 @@ ng_rollup_bundle(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(["*_spec.ts"]),
deps = [
"//packages:types",

View File

@ -31,7 +31,7 @@ ng_rollup_bundle(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(["*_spec.ts"]),
deps = [
":injection",

View File

@ -37,7 +37,7 @@ ng_rollup_bundle(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(["*_spec.ts"]),
deps = [
"//packages:types",
@ -56,8 +56,6 @@ jasmine_node_test(
":bundle.min_debug.js",
],
tags = [
"ivy-jit",
"ivy-local",
"ivy-only",
],
deps = [":test_lib"],
@ -68,7 +66,6 @@ js_expected_symbol_test(
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-local",
"ivy-only",
],
)

View File

@ -41,7 +41,7 @@ ng_rollup_bundle(
ts_library(
name = "test_lib",
testonly = 1,
testonly = True,
srcs = glob(["*_spec.ts"]),
deps = [
"//packages:types",
@ -62,8 +62,6 @@ jasmine_node_test(
":bundle.min_debug.js",
],
tags = [
"ivy-jit",
"ivy-local",
"ivy-only",
],
deps = [":test_lib"],
@ -74,7 +72,6 @@ js_expected_symbol_test(
src = ":bundle.min_debug.js",
golden = ":bundle.golden_symbols.json",
tags = [
"ivy-local",
"ivy-only",
],
)