test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags (#26471)
We are close enough to blacklist a few test targets, rather than whitelist targets to run... Because bazel rules can be composed of other rules that don't inherit tags automatically, I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and "ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even if those targets are composed of other targets that don't inherit this tag. This is the updated overview of ivy related bazel tags: - ivy-only: target that builds or runs only under ivy - fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit - fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local - no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit - no-ivy-local: target that is not intended to build or run under ivy with --compile=local PR Close #26471
This commit is contained in:

committed by
Alex Rickabaugh

parent
361eaf1888
commit
4237c34c78
@ -29,8 +29,6 @@ ng_package(
|
||||
],
|
||||
entry_point = "packages/platform-browser/index.js",
|
||||
tags = [
|
||||
"ivy-jit",
|
||||
"ivy-local",
|
||||
"release-with-framework",
|
||||
],
|
||||
deps = [
|
||||
|
46
packages/platform-browser/animations/test/BUILD.bazel
Normal file
46
packages/platform-browser/animations/test/BUILD.bazel
Normal file
@ -0,0 +1,46 @@
|
||||
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library", "ts_web_test_suite")
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = True,
|
||||
srcs = glob(["**/*.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
"//packages/animations",
|
||||
"//packages/animations/browser",
|
||||
"//packages/animations/browser/testing",
|
||||
"//packages/common",
|
||||
"//packages/compiler",
|
||||
"//packages/core",
|
||||
"//packages/core/testing",
|
||||
"//packages/platform-browser",
|
||||
"//packages/platform-browser-dynamic",
|
||||
"//packages/platform-browser/animations",
|
||||
"//packages/platform-browser/testing",
|
||||
"@rxjs",
|
||||
],
|
||||
)
|
||||
|
||||
jasmine_node_test(
|
||||
name = "test",
|
||||
bootstrap = ["angular/tools/testing/init_node_spec.js"],
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
"//tools/testing:node",
|
||||
],
|
||||
)
|
||||
|
||||
ts_web_test_suite(
|
||||
name = "test_web",
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
],
|
||||
)
|
@ -11,8 +11,9 @@ import {Component, Injectable, NgZone, RendererFactory2, RendererType2, ViewChil
|
||||
import {TestBed} from '@angular/core/testing';
|
||||
import {BrowserAnimationsModule, ɵAnimationRendererFactory as AnimationRendererFactory} from '@angular/platform-browser/animations';
|
||||
import {DomRendererFactory2} from '@angular/platform-browser/src/dom/dom_renderer';
|
||||
import {InjectableAnimationEngine} from '../../animations/src/providers';
|
||||
|
||||
import {el} from '../../testing/src/browser_util';
|
||||
import {InjectableAnimationEngine} from '../src/providers';
|
||||
|
||||
(function() {
|
||||
if (isNode) return;
|
||||
@ -282,7 +283,7 @@ import {el} from '../../testing/src/browser_util';
|
||||
@Component({
|
||||
selector: 'my-cmp',
|
||||
template: `
|
||||
<div [@myAnimation]="exp"></div>
|
||||
<div [@myAnimation]="exp"></div>
|
||||
`,
|
||||
animations: [trigger('myAnimation', [])]
|
||||
})
|
@ -12,8 +12,8 @@ import {Component, ViewChild} from '@angular/core';
|
||||
import {TestBed, fakeAsync, flushMicrotasks} from '@angular/core/testing';
|
||||
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
|
||||
|
||||
import {BrowserAnimationBuilder} from '../../animations/src/animation_builder';
|
||||
import {el} from '../../testing/src/browser_util';
|
||||
import {BrowserAnimationBuilder} from '../src/animation_builder';
|
||||
|
||||
{
|
||||
describe('BrowserAnimationBuilder', () => {
|
@ -7,7 +7,7 @@ exports_files([
|
||||
|
||||
ts_library(
|
||||
name = "test_lib",
|
||||
testonly = 1,
|
||||
testonly = True,
|
||||
srcs = glob(["**/*.ts"]),
|
||||
deps = [
|
||||
"//packages:types",
|
||||
@ -29,7 +29,10 @@ ts_library(
|
||||
jasmine_node_test(
|
||||
name = "test",
|
||||
bootstrap = ["angular/tools/testing/init_node_spec.js"],
|
||||
# dissable since tests are running but not yet passing
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
"//tools/testing:node",
|
||||
@ -41,6 +44,10 @@ ts_web_test_suite(
|
||||
static_files = [
|
||||
":static_assets/test.html",
|
||||
],
|
||||
tags = [
|
||||
"fixme-ivy-jit",
|
||||
"fixme-ivy-local",
|
||||
],
|
||||
deps = [
|
||||
":test_lib",
|
||||
],
|
||||
|
Reference in New Issue
Block a user