From 44e604b131bccc33599c8cc41739082cc233d006 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Mon, 22 Oct 2018 18:02:42 -0700 Subject: [PATCH] build: add source-map-support to various rules within our repo (#26471) This removes an verbose warning and adds source-mapping support to our build/ci. Related issue: https://github.com/bazelbuild/rules_nodejs/issues/389 PR Close #26471 --- packages/bazel/src/ngc-wrapped/BUILD.bazel | 2 ++ tools/defaults.bzl | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/bazel/src/ngc-wrapped/BUILD.bazel b/packages/bazel/src/ngc-wrapped/BUILD.bazel index f1f21cb170..f338fd272d 100644 --- a/packages/bazel/src/ngc-wrapped/BUILD.bazel +++ b/packages/bazel/src/ngc-wrapped/BUILD.bazel @@ -33,6 +33,7 @@ nodejs_binary( data = [ ":ngc_lib", "@build_bazel_rules_typescript//third_party/github.com/bazelbuild/bazel/src/main/protobuf:worker_protocol.proto", + "@ngdeps//source-map-support", "@ngdeps//tslib", ], entry_point = "angular/packages/bazel/src/ngc-wrapped/index.js", @@ -43,6 +44,7 @@ nodejs_binary( name = "xi18n", data = [ ":ngc_lib", + "@ngdeps//source-map-support", ], entry_point = "angular/packages/bazel/src/ngc-wrapped/extract_i18n.js", visibility = ["//visibility:public"], diff --git a/tools/defaults.bzl b/tools/defaults.bzl index 75e3ae78e0..ecfb406e74 100644 --- a/tools/defaults.bzl +++ b/tools/defaults.bzl @@ -179,11 +179,12 @@ def ts_web_test_suite(bootstrap = [], deps = [], tags = [], **kwargs): **kwargs ) -def nodejs_binary(**kwargs): +def nodejs_binary(data = [], **kwargs): """Default values for nodejs_binary""" _nodejs_binary( # Pass-thru --define=compile=foo as an environment variable configuration_env_vars = ["compile"], + data = data + ["@ngdeps//source-map-support"], **kwargs ) @@ -197,6 +198,7 @@ def jasmine_node_test(deps = [], tags = [], **kwargs): "@ngdeps//jasmine-core", "@ngdeps//mock-fs", "@ngdeps//reflect-metadata", + "@ngdeps//source-map-support", "@ngdeps//tslib", "@ngdeps//xhr2", ]