cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(core): remove backwards compatibility of SimpleChange

Browse Source 
BREAKING CHANGE:
`SimnpleChange` now takes an additional argument that defines
whether this is the first change or not.
This commit is contained in:
Tobias Bosch 2017-01-03 11:58:49 -08:00 committed by Igor Minar
parent db49d422f2
commit 465516b905
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/@angular/core/src/change_detection/change_detection_util.ts
View File

@ -71,15 +71,10 @@ export class ValueUnwrapper {
* @stable * @stable
*/ */
export class SimpleChange { export class SimpleChange {
constructor( constructor(public previousValue: any, public currentValue: any, public firstChange: boolean) {}
public previousValue: any, public currentValue: any, _isFirstChange: boolean = false) {
// Store this in a non declared field
// to prevent a breaking change (users might have `implement`ed SimpleChange before)
(<any>this)._firstChange = _isFirstChange;
}
/** /**
* Check whether the new value is the first value assigned. * Check whether the new value is the first value assigned.
*/ */
isFirstChange(): boolean { return (<any>this)._firstChange; } isFirstChange(): boolean { return this.firstChange; }
} }

3
tools/public_api_guard/core/index.d.ts vendored
View File

@ -842,8 +842,9 @@ export declare function setTestabilityGetter(getter: GetTestability): void;
/** @stable */ /** @stable */
export declare class SimpleChange { export declare class SimpleChange {
currentValue: any; currentValue: any;
firstChange: boolean;
previousValue: any; previousValue: any;
constructor(previousValue: any, currentValue: any, _isFirstChange?: boolean); constructor(previousValue: any, currentValue: any, firstChange: boolean);
isFirstChange(): boolean; isFirstChange(): boolean;
} }