cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: make git revert messages valid (#22339)

Browse Source 
`git revert` default message is "Revert <original message>" (no semi-colon)

PR Close #22339
This commit is contained in:
Victor Berchet 2018-02-20 17:11:10 -08:00
parent ee535777bb
commit 484802cd2a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/validate-commit-message/validate-commit-message.js
View File

@ -22,7 +22,7 @@ const configPath = path.resolve(__dirname, './commit-message.json');
const config = JSON.parse(fs.readFileSync(configPath, 'utf8')); const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
const PATTERN = /^(\w+)(?:\(([^)]+)\))?\: (.+)$/; const PATTERN = /^(\w+)(?:\(([^)]+)\))?\: (.+)$/;
const FIXUP_SQUASH = /^(fixup|squash)\! /i; const FIXUP_SQUASH = /^(fixup|squash)\! /i;
const REVERT = /^revert: (\"(.*)\"|(.*))?$/i; const REVERT = /^revert:? (\"(.*)\"|(.*))?$/i;
module.exports = function(commitSubject) { module.exports = function(commitSubject) {
commitSubject = commitSubject.replace(FIXUP_SQUASH, ''); commitSubject = commitSubject.replace(FIXUP_SQUASH, '');

2
tools/validate-commit-message/validate-commit-message.spec.js
View File

@ -45,10 +45,10 @@ describe('validate-commit-message.js', function() {
expect(validateMessage('fixup! release(packaging): something')).toBe(VALID); expect(validateMessage('fixup! release(packaging): something')).toBe(VALID);
expect(validateMessage('squash! release(packaging): something')).toBe(VALID); expect(validateMessage('squash! release(packaging): something')).toBe(VALID);
expect(validateMessage('Revert: "release(packaging): something"')).toBe(VALID); expect(validateMessage('Revert: "release(packaging): something"')).toBe(VALID);
expect(validateMessage('Revert "release(packaging): something"')).toBe(VALID);
expect(errors).toEqual([]); expect(errors).toEqual([]);
}); });
it('should fail when scope is invalid', function() { it('should fail when scope is invalid', function() {
expect(validateMessage('fix(Compiler): something')).toBe(INVALID); expect(validateMessage('fix(Compiler): something')).toBe(INVALID);
expect(validateMessage('feat(bah): something')).toBe(INVALID); expect(validateMessage('feat(bah): something')).toBe(INVALID);