cargdev/angular
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(service-worker): Fix public api guard typing (#25860)

Browse Source 
PR Close #25860
This commit is contained in:
Joost Zöllner
2018-09-28 10:28:53 +02:00
committed by Kara Erickson
parent 10618752e6
commit 4a01ada291
8 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/service-worker/worker/src/driver.ts
View File

@ -29,13 +29,9 @@ const IDLE_THRESHOLD = 5000;
const SUPPORTED_CONFIG_VERSION = 1;
const NOTIFICATION_OPTION_NAMES = [
'actions', 'badge', 'body', 'dir', 'icon', 'lang', 'renotify', 'requireInteraction', 'tag',
'vibrate', 'data'
];
const NOTIFICATION_CLICK_OPTION_NAMES = [
'actions', 'badge', 'title', 'body', 'dir', 'icon', 'image', 'lang', 'renotify',
'requireInteraction', 'tag', 'timestamp', 'vibrate', 'data'
const NOTIFICATION_OPTION_NAMES: (keyof Notification)[] = [
'actions', 'badge', 'body', 'data', 'dir', 'icon', 'image', 'lang', 'renotify',
'requireInteraction', 'silent', 'tag', 'timestamp', 'title', 'vibrate'
];
interface LatestEntry {
@ -312,10 +308,9 @@ export class Driver implements Debuggable, UpdateSource {
private async handleClick(notification: Notification, action?: string): Promise<void> {
notification.close();
const desc = notification as any;
let options: {[key: string]: string | undefined} = {};
NOTIFICATION_CLICK_OPTION_NAMES.filter(name => desc.hasOwnProperty(name))
.forEach(name => options[name] = desc[name]);
const options: {-readonly[K in keyof Notification]?: Notification[K]} = {};
NOTIFICATION_OPTION_NAMES.filter(name => name in notification)
.forEach(name => options[name] = notification[name]);
await this.broadcast({
type: 'NOTIFICATION_CLICK',