cargdev/angular
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

ci: minor PullApprove fixes/improvements (#35015)

Browse Source 
This is a follow-up to #34814 to fix some typos in patterns and make
them more similar to the old patterns from `.github/CODEOWNERS`.

PR Close #35015
This commit is contained in:
George Kalpakas
2020-01-28 22:52:49 +02:00
committed by Andrew Kushnir
parent 4975f89fdd
commit 4bc0abf003
3 changed files with 56 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/TRIAGE_AND_LABELS.md
View File

@ -173,6 +173,9 @@ Before a PR can be merged it must be approved by the appropriate reviewer(s).
To ensure that the right people review each change, we set review requests using [PullApprove](https://https://docs.pullapprove.com/) (via `.pullapprove`) and require that each PR has at least one approval from an appropriate code owner.
If the PR author is a code owner themselves, the approval can come from _any_ repo collaborator (person with write access).
In any case, the reviewer should actually look through the code and provide feedback if necessary.
Note that approved state does not mean a PR is ready to be merged.
For example, a reviewer might approve the PR but request a minor tweak that doesn't need further review, e.g., a rebase or small uncontroversial change.
Only the `PR action: merge` label means that the PR is ready for merging.