cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: exclude ngcc directory from fw-compiler pull-approve rule (#35933)

Browse Source 
ngcc has its own pull-approve group

PR Close #35933
This commit is contained in:
Pete Bacon Darwin 2020-03-07 16:23:11 +00:00 committed by Kara Erickson
parent f9fb8338f5
commit 4c7f89ff6d
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.pullapprove.yml
View File

@ -123,10 +123,10 @@ pullapprove_conditions:
groups: groups:
# ========================================================= # =========================================================
# Global Approvers # Global Approvers
# #
# All reviews performed for global approvals require using # All reviews performed for global approvals require using
# the `Reviewed-for:` specifier to set the approval # the `Reviewed-for:` specifier to set the approval
# specificity as documented at: # specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/ # https://docs.pullapprove.com/reviewed-for/
# ========================================================= # =========================================================
global-approvers: global-approvers:
@ -141,10 +141,10 @@ groups:
# ========================================================= # =========================================================
# Global Approvers For Docs # Global Approvers For Docs
# #
# All reviews performed for global docs approvals require # All reviews performed for global docs approvals require
# using the `Reviewed-for:` specifier to set the approval # using the `Reviewed-for:` specifier to set the approval
# specificity as documented at: # specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/ # https://docs.pullapprove.com/reviewed-for/
# ========================================================= # =========================================================
global-docs-approvers: global-docs-approvers:
@ -198,6 +198,10 @@ groups:
'aio/content/guide/aot-metadata-errors.md', 'aio/content/guide/aot-metadata-errors.md',
'aio/content/guide/template-typecheck.md ' 'aio/content/guide/template-typecheck.md '
]) ])
- >
not contains_any_globs(files, [
'packages/compiler-cli/ngcc/**'
])
reviewers: reviewers:
users: users:
- alxhub - alxhub