cargdev/angular
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove various leftover unused or deprecated code (#11091)

Browse Source
This commit is contained in:
Igor Minar
2016-08-26 09:12:27 -07:00
committed by Victor Berchet
parent 0cf5ece7f8
commit 4d7d2a2daa
8 changed files with 1 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/@angular/compiler/src/compile_metadata.ts
View File

@ -442,8 +442,6 @@ export class CompileDirectiveMetadata implements CompileMetadataWithIdentifier {
hostProperties[matches[1]] = value;
} else if (isPresent(matches[2])) {
hostListeners[matches[2]] = value;
} else if (isPresent(matches[3])) { // DEPRECATED: remove this if statement post RC5
hostProperties['@' + matches[3]] = value;
}
});
}

6
modules/@angular/compiler/src/expression_parser/lexer.ts
View File

@ -57,10 +57,6 @@ export class Token {
isKeyword(): boolean { return this.type == TokenType.Keyword; }
isKeywordDeprecatedVar(): boolean {
return this.type == TokenType.Keyword && this.strValue == 'var';
}
isKeywordLet(): boolean { return this.type == TokenType.Keyword && this.strValue == 'let'; }
isKeywordNull(): boolean { return this.type == TokenType.Keyword && this.strValue == 'null'; }
@ -392,4 +388,4 @@ function unescape(code: number): number {
default:
return code;
}
}
}

6
modules/@angular/compiler/src/template_parser/template_parser.ts
View File

@ -821,12 +821,6 @@ class TemplateParseVisitor implements html.Visitor {
boundPropertyName = partValue.substr(1);
bindingType = PropertyBindingType.Animation;
securityContext = SecurityContext.NONE;
if (boundPropertyName[0] == '@') {
this._reportError(
`Assigning animation triggers within host data as attributes such as "@prop": "exp" is invalid. Use host bindings (e.g. "[@prop]": "exp") instead.`,
sourceSpan, ParseErrorLevel.FATAL);
boundPropertyName = boundPropertyName.substr(1);
}
} else {
boundPropertyName = this._schemaRegistry.getMappedPropName(partValue);
securityContext = this._schemaRegistry.securityContext(elementName, boundPropertyName);

15
modules/@angular/compiler/test/template_parser/template_parser_spec.ts
View File

@ -301,21 +301,6 @@ Can't bind to 'invalidProp' since it isn't a known property of 'my-component'.
/Assigning animation triggers via @prop="exp" attributes with an expression is invalid. Use property bindings \(e.g. \[@prop\]="exp"\) or use an attribute without a value \(e.g. @prop\) instead. \("<div \[ERROR ->\]@something="value2">"\): TestComp@0:5/);
});
it('should throw an error when host attributes contain a non property-bound animation trigger',
() => {
expect(() => {
var dirA = CompileDirectiveMetadata.create({
selector: 'div',
type: new CompileTypeMetadata({moduleUrl: someModuleUrl, name: 'DirA'}),
host: {'@prop': 'expr'}
});
humanizeTplAst(parse('<div></div>', [dirA]));
})
.toThrowError(
/Assigning animation triggers within host data as attributes such as "@prop": "exp" is invalid. Use host bindings \(e.g. "\[@prop\]": "exp"\) instead. \("\[ERROR ->\]<div><\/div>"\): TestComp@0:0, Directive DirA/);
});
it('should not issue a warning when host attributes contain a valid property-bound animation trigger',
() => {
var dirA = CompileDirectiveMetadata.create({