ci: do not run benchmark measurements in circleci (#34753)
Currently we run all benchmark perf tests in CircleCI. Since we do not collect any results, we unnecessarily waste CI/RBE resources. Instead, we should just not run benchmark perf tests in CI, but still run the functionality e2e tests which ensure that benchmarks are not broken. We can do this by splitting the perf and e2e tests into separate files/targets. PR Close #34753
This commit is contained in:

committed by
Andrew Kushnir

parent
669df70da5
commit
4d88b4bc26
@ -3,7 +3,8 @@ load("//tools:defaults.bzl", "protractor_web_test_suite")
|
||||
"""
|
||||
Macro that can be used to define a benchmark test. This differentiates from
|
||||
a normal Protractor test suite because we specify a custom "perf" configuration
|
||||
that sets up "@angular/benchpress".
|
||||
that sets up "@angular/benchpress". Benchmark test targets will not run on CI
|
||||
unless explicitly requested.
|
||||
"""
|
||||
|
||||
def benchmark_test(name, server, deps, tags = []):
|
||||
@ -15,7 +16,9 @@ def benchmark_test(name, server, deps, tags = []):
|
||||
],
|
||||
on_prepare = "//modules/benchmarks:start-server.js",
|
||||
server = server,
|
||||
tags = tags,
|
||||
# Benchmark targets should not run on CI by default.
|
||||
tags = tags + ["manual"],
|
||||
test_suite_tags = ["manual"],
|
||||
deps = [
|
||||
"@npm//yargs",
|
||||
] + deps,
|
||||
|
Reference in New Issue
Block a user