ci: do not run benchmark measurements in circleci (#34753)
Currently we run all benchmark perf tests in CircleCI. Since we do not collect any results, we unnecessarily waste CI/RBE resources. Instead, we should just not run benchmark perf tests in CI, but still run the functionality e2e tests which ensure that benchmarks are not broken. We can do this by splitting the perf and e2e tests into separate files/targets. PR Close #34753
This commit is contained in:

committed by
Andrew Kushnir

parent
669df70da5
commit
4d88b4bc26
17
modules/benchmarks/e2e_test.bzl
Normal file
17
modules/benchmarks/e2e_test.bzl
Normal file
@ -0,0 +1,17 @@
|
||||
load("//tools:defaults.bzl", "protractor_web_test_suite")
|
||||
|
||||
"""
|
||||
Macro that can be used to define a e2e test in `modules/benchmarks`. Targets created through
|
||||
this macro differentiate from a "benchmark_test" as they will run on CI and do not run
|
||||
with `@angular/benchpress`.
|
||||
"""
|
||||
|
||||
def e2e_test(name, server, deps, **kwargs):
|
||||
protractor_web_test_suite(
|
||||
name = name,
|
||||
on_prepare = "//modules/benchmarks:start-server.js",
|
||||
server = server,
|
||||
# `yargs` is needed as runtime dependency for the e2e utils.
|
||||
deps = ["@npm//yargs"] + deps,
|
||||
**kwargs
|
||||
)
|
Reference in New Issue
Block a user