cargdev/angular
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

ci: do not run benchmark measurements in circleci (#34753)

Browse Source 
Currently we run all benchmark perf tests in CircleCI. Since we do not
collect any results, we unnecessarily waste CI/RBE resources. Instead,
we should just not run benchmark perf tests in CI, but still run the
functionality e2e tests which ensure that benchmarks are not broken.

We can do this by splitting the perf and e2e tests into separate
files/targets.

PR Close #34753
This commit is contained in:
Paul Gschwendtner
2020-01-13 18:57:06 +01:00
committed by Andrew Kushnir
parent 669df70da5
commit 4d88b4bc26
33 changed files with 344 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/e2e_util/e2e_util.ts
View File

@ -12,7 +12,7 @@ import {browser} from 'protractor';
const yargs = require('yargs');
import * as webdriver from 'selenium-webdriver';
let cmdArgs: {'bundles': boolean};
let cmdArgs: {'bundles': boolean}|undefined;
declare var expect: any;
@ -39,7 +39,7 @@ export function openBrowser(config: {
browser.ignoreSynchronization = true;
}
let params = config.params || [];
if (!params.some((param) => param.name === 'bundles')) {
if (cmdArgs !== undefined && !params.some((param) => param.name === 'bundles')) {
params = params.concat([{name: 'bundles', value: cmdArgs.bundles}]);
}