refactor(ivy): generate ngFactoryDef for injectables (#32433)
With #31953 we moved the factories for components, directives and pipes into a new field called `ngFactoryDef`, however I decided not to do it for injectables, because they needed some extra logic. These changes set up the `ngFactoryDef` for injectables as well. For reference, the extra logic mentioned above is that for injectables we have two code paths: 1. For injectables that don't configure how they should be instantiated, we create a `factory` that proxies to `ngFactoryDef`: ``` // Source @Injectable() class Service {} // Output class Service { static ngInjectableDef = defineInjectable({ factory: () => Service.ngFactoryFn(), }); static ngFactoryFn: (t) => new (t || Service)(); } ``` 2. For injectables that do configure how they're created, we keep the `ngFactoryDef` and generate the factory based on the metadata: ``` // Source @Injectable({ useValue: DEFAULT_IMPL, }) class Service {} // Output export class Service { static ngInjectableDef = defineInjectable({ factory: () => DEFAULT_IMPL, }); static ngFactoryFn: (t) => new (t || Service)(); } ``` PR Close #32433
This commit is contained in:
@ -353,10 +353,14 @@ export class IvyCompilation {
|
||||
const compileMatchRes =
|
||||
match.handler.compile(node as ClassDeclaration, match.analyzed.analysis, constantPool);
|
||||
this.perf.stop(compileSpan);
|
||||
if (!Array.isArray(compileMatchRes)) {
|
||||
if (Array.isArray(compileMatchRes)) {
|
||||
compileMatchRes.forEach(result => {
|
||||
if (!res.some(r => r.name === result.name)) {
|
||||
res.push(result);
|
||||
}
|
||||
});
|
||||
} else if (!res.some(result => result.name === compileMatchRes.name)) {
|
||||
res.push(compileMatchRes);
|
||||
} else {
|
||||
res.push(...compileMatchRes);
|
||||
}
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user