From 4e6efb361df2599c2ff13361b8c314a625bf2ee3 Mon Sep 17 00:00:00 2001 From: Jason Aden Date: Mon, 11 Mar 2019 09:52:50 -0700 Subject: [PATCH] docs: remove 'PR target: review' label (#29227) We have switched to using Github's `Review` feature to request and track if a PR needs review. Therefore this label can be removed. PR Close #29227 --- docs/TRIAGE_AND_LABELS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/TRIAGE_AND_LABELS.md b/docs/TRIAGE_AND_LABELS.md index c905b742a7..de95fabd79 100644 --- a/docs/TRIAGE_AND_LABELS.md +++ b/docs/TRIAGE_AND_LABELS.md @@ -111,7 +111,6 @@ Triaging PRs is the same as triaging issues, except that PRs have additional lab Every triaged PR must have a `pr_action` label assigned to it: -* `PR action: review` - work is complete and comment is needed from the reviewers. * `PR action: cleanup` - more work is needed from the author. * `PR action: discuss` - discussion is needed, to be led by the author. * `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready". @@ -122,6 +121,8 @@ In addition, PRs can have the following states: * `PR state: WIP` - PR is experimental or rapidly changing. Not ready for review or triage. * `PR state: blocked` - PR is blocked on an issue or other PR. Not ready for review or triage or merge. +When a PR is ready for review, a review should be requested using the Reviewers interface in Github. + ## PR Target